Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rm command #21

Closed
6 tasks done
ChacaS0 opened this issue Mar 14, 2018 · 2 comments
Closed
6 tasks done

Improve rm command #21

ChacaS0 opened this issue Mar 14, 2018 · 2 comments
Assignees
@ChacaS0
Labels
beta Stuff for/from the beta doc Operation on documentation enhancement Improvement of existing feature test stuff to do about testing (unit tests, live tests, etc) todo when it needs to be done website When it's about gh-pages or a website to/about TEMPest
Milestone
v0.2B

Comments

@ChacaS0
Copy link
Owner

ChacaS0 commented Mar 14, 2018 •
edited
Loading

In short

The tempest rm is a nice command but not so convenient to use. It just needs some enhancement.

Examples

We should be able to remove targets from the TEMPest list with a command like tempest rm -i 0-2 or tempest rm -i 0 3 or tempest -p /path1 /path2

In depth

So the 0-2 would remove all targets from 0 to 2 from TEMPest list.
0 3 would remove targets with index 0 and 3.
Should be able to do the same with the full path name.

In addition

Update and/or create documentation about that
➕ Use this opportunity to finish the --origin flag 😜

TODOs

  • add the thing
  • write the code ofc
  • write doc
  • udpate tests
  • update rm tutorial (gh-pages)
  • same for --origin
@ChacaS0 ChacaS0 added enhancement Improvement of existing feature todo when it needs to be done beta Stuff for/from the beta doc Operation on documentation test stuff to do about testing (unit tests, live tests, etc) labels Mar 14, 2018
@ChacaS0 ChacaS0 added this to the v0.2B milestone Mar 14, 2018
@ChacaS0 ChacaS0 self-assigned this Mar 14, 2018
@ChacaS0 ChacaS0 added the website When it's about gh-pages or a website to/about TEMPest label Mar 25, 2018
ChacaS0 added a commit that referenced this issue Mar 25, 2018
@ChacaS0
🚧 Work on rework of rm command starts -- bad
09ae5df 
 Issues related:
 	-> #21 Improve ``rm`` command

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
ChacaS0 added a commit that referenced this issue Mar 27, 2018
@ChacaS0
✔️🏁 processArgsRm added + tests
fb436d1 
 Issues related:
 	-> #21
 	-> #16
 	-> #9

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
ChacaS0 added a commit that referenced this issue Mar 28, 2018
@ChacaS0
✔️🏁 New feature for rm
b35ca71 
	-> Added & adapted tests only for the ones impacted by those changes

 Issues related:
 	-> #21
 	-> #16

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
	modified:   cmd/root.go
ChacaS0 added a commit that referenced this issue Mar 28, 2018
@ChacaS0
💻🏁 Added test for rm.go:simpleDelAllString()
856d8d8 
	-> Few changes (variadic params instead of slice)
	-> Some update for the ``$HOME`` on Windows

 Issues related:
 	-> #21
 	-> #16
 	-> #9

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/purge.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
	modified:   cmd/root.go
@ChacaS0
Copy link
Owner Author

ChacaS0 commented Mar 29, 2018

🐛❗ After 856d8d8, using rm on multiple values doesn't and duplicates some targets

@ChacaS0
Copy link
Owner Author

ChacaS0 commented Mar 29, 2018

TODO: doc stuff

@ChacaS0 ChacaS0 mentioned this issue Mar 30, 2018
Merged
6 tasks
ChacaS0 added a commit that referenced this issue Mar 30, 2018
@ChacaS0
⬆️ Update of usage for the rm command
18673a8 
 Issues related:
 	-> #21

 On branch gh-pages
 Your branch is up to date with 'origin/gh-pages'.

 Changes to be committed:
	modified:   _includes/wallet/rm.md
ChacaS0 added a commit that referenced this issue Mar 31, 2018
@ChacaS0
✔️🏁 Added handler for * wildcard as argument
3019a18 
	-> Tests, were adapted for that

 Issues related:
 	-> #21

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
ChacaS0 added a commit that referenced this issue Mar 31, 2018
@ChacaS0
📝 Update of usage for rm and deletion of deprecated stuff
4dde5fe 
 Issues related:
 	-> #21
 	-> #19

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
ChacaS0 added a commit that referenced this issue Mar 31, 2018
@ChacaS0
Improvement of the rm command (#21) (#25)
adee1cc 
* ✔️ Mispells fixes

 On branch devel
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/list.go
	modified:   cmd/list_test.go
	modified:   cmd/rm_test.go
	modified:   cmd/start_test.go

* 🚧 Work on rework of rm command starts -- bad

 Issues related:
 	-> #21 Improve ``rm`` command

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go

* 💊 Fixed missspelling

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/list.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go

* ✔️🏁 processArgsRm added + tests

 Issues related:
 	-> #21
 	-> #16
 	-> #9

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go

* ✔️🏁 New feature for rm
	-> Added & adapted tests only for the ones impacted by those changes

 Issues related:
 	-> #21
 	-> #16

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
	modified:   cmd/root.go

* 💻🏁 Added test for rm.go:simpleDelAllString()
	-> Few changes (variadic params instead of slice)
	-> Some update for the ``$HOME`` on Windows

 Issues related:
 	-> #21
 	-> #16
 	-> #9

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/purge.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
	modified:   cmd/root.go

* ✔️🏁 Added handler for ``*`` wildcard as argument
	-> Tests, were adapted for that

 Issues related:
 	-> #21

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go

* 📝 Update of usage for ``rm`` and deletion of deprecated stuff

 Issues related:
 	-> #21
 	-> #19

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
@ChacaS0 ChacaS0 closed this as completed Mar 31, 2018
@ChacaS0 ChacaS0 mentioned this issue Mar 31, 2018
Merged
ChacaS0 added a commit that referenced this issue May 1, 2018
@ChacaS0
Apply patch v0.2B (#26)
19ca504 
* ✔️ Mispells fixes

* Improvement of the ``rm`` command (#21) (#25)

* ✔️ Mispells fixes

* 🚧 Work on rework of rm command starts -- bad

* 💊 Fixed missspelling

* ✔️🏁 processArgsRm added + tests

* ✔️🏁 New feature for rm
	-> Added & adapted tests only for the ones impacted by those changes

* 💻🏁 Added test for rm.go:simpleDelAllString()
	-> Few changes (variadic params instead of slice)
	-> Some update for the ``$HOME`` on Windows

* ✔️🏁 Added handler for ``*`` wildcard as argument
	-> Tests, were adapted for that

* 📝 Update of usage for ``rm`` and deletion of deprecated stuff

* Implementation of ``tempest list --fix`` flag (#27)

* 🚧 Added the functionality, now needs the tests

* 🏁 Tests for list.go (``--fix`` flag related)
	+ Begin of migration to the use of Target instead of simple strings

-----------------------
Merge Fixes #20

* 🔨 Auto mode for TEMPest (#28)

* 🚧 Moved configs files for TEMpest into a directory
	[+] Added .sh for auto-mode
	--> Issues related: #24, #15
* Handler for shutup mode made, need merge
* Stash pop
* 🏁 Added tests for shutup mode handler (start.go)
	-> Issues related: #15, #16
* ✔️🏁 Added logs flag for get command
	[+] Added the corresponding test
	--> Issues related: #15, #16
* ✔️ Added handler for relative paths with ``add``
* 🏁 Added tests for treatRelativePath()
* 🏁 Test for getAllLogs() (--logs)
	--> Issues related: #15, #16
	[*] Should be the end of the Linux part for this one
* 💻 Windows autostart kinda done for theoric part
	[#] Issues related: #15, #9
	[T] Unit tests for set.go:setAutoStart()
	[T] Runtime testing for Windows
* 📛 Hot fix for codecov chmod
* 🏁 Test only for error checks
	[I] #15, #16
	[T] More elaborated tests for setAutoStart()
	[#] Fixes #15

* ➕ New flag for get (auto-mode)
	[+] Also implemented test func for it
	[#] Issues: #15, #16

* 📝 Update of README.md

* ⬆️ dep ensure

* Manage temp files (#30)

* 🚧 Started to refractor purge to purge files
	[T] Keep refratoring each functions affected
	[#] Issues: #17
	[N] Some comments were deleted (cobra related)

* New func to display size + units

* 📄🚽 Implemented the file purging
	[T] Tests
	[#] #30, #17

* 🏁 Tests for purge
👉 Apply TreatLastChar() to conf.Gobin & conf.Gopath
ChacaS0 added a commit that referenced this issue Jun 8, 2018
@ChacaS0
Patch v0.1 (#36)
76f2192 
* ✔️ Mispells fixes

 On branch devel
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/list.go
	modified:   cmd/list_test.go
	modified:   cmd/rm_test.go
	modified:   cmd/start_test.go

* Improvement of the ``rm`` command (#21) (#25)

* ✔️ Mispells fixes

 On branch devel
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/list.go
	modified:   cmd/list_test.go
	modified:   cmd/rm_test.go
	modified:   cmd/start_test.go

* 🚧 Work on rework of rm command starts -- bad

 Issues related:
 	-> #21 Improve ``rm`` command

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go

* 💊 Fixed missspelling

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/list.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go

* ✔️🏁 processArgsRm added + tests

 Issues related:
 	-> #21
 	-> #16
 	-> #9

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/init_test.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go

* ✔️🏁 New feature for rm
	-> Added & adapted tests only for the ones impacted by those changes

 Issues related:
 	-> #21
 	-> #16

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
	modified:   cmd/root.go

* 💻🏁 Added test for rm.go:simpleDelAllString()
	-> Few changes (variadic params instead of slice)
	-> Some update for the ``$HOME`` on Windows

 Issues related:
 	-> #21
 	-> #16
 	-> #9

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/purge.go
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go
	modified:   cmd/root.go

* ✔️🏁 Added handler for ``*`` wildcard as argument
	-> Tests, were adapted for that

 Issues related:
 	-> #21

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go
	modified:   cmd/rm_test.go

* 📝 Update of usage for ``rm`` and deletion of deprecated stuff

 Issues related:
 	-> #21
 	-> #19

 On branch dev-enhancement-rm
 Changes to be committed:
	modified:   cmd/rm.go

* Implementation of ``tempest list --fix`` flag (#27)

* 🚧 Added the functionality, now needs the tests

 Issues related:
 	-> #20

* 🏁 Tests for list.go (``--fix`` flag related)
	+ Begin of migration to the use of Target instead of simple strings

 Issues related:
 	-> #20

-----------------------
Merge Fixes #20

* 🔨 Auto mode for TEMPest (#28)

* 🚧 Moved configs files for TEMpest into a directory
	[+] Added .sh for auto-mode
	--> Issues related: #24, #15
* Handler for shutup mode made, need merge
* Stash pop
* 🏁 Added tests for shutup mode handler (start.go)
	-> Issues related: #15, #16
* ✔️🏁 Added logs flag for get command
	[+] Added the corresponding test
	--> Issues related: #15, #16
* ✔️ Added handler for relative paths with ``add``
* 🏁 Added tests for treatRelativePath()
* 🏁 Test for getAllLogs() (--logs)
	--> Issues related: #15, #16
	[*] Should be the end of the Linux part for this one
* 💻 Windows autostart kinda done for theoric part
	[#] Issues related: #15, #9
	[T] Unit tests for set.go:setAutoStart()
	[T] Runtime testing for Windows
* 📛 Hot fix for codecov chmod
* 🏁 Test only for error checks
	[I] #15, #16
	[T] More elaborated tests for setAutoStart()
	[#] Fixes #15

* ➕ New flag for get (auto-mode)
	[+] Also implemented test func for it
	[#] Issues: #15, #16

* 📝 Update of README.md

* ⬆️ dep ensure

* Manage temp files (#30)

* 🚧 Started to refractor purge to purge files
	[T] Keep refratoring each functions affected
	[#] Issues: #17
	[N] Some comments were deleted (cobra related)

* New func to display size + units

* 📄🚽 Implemented the file purging
	[T] Tests
	[#] #30, #17

* 🏁 Tests for purge
👉 Apply TreatLastChar() to conf.Gobin & conf.Gopath

* Targets automation (#34)

* ✔️ Func to find dirs from exact pattern added

* ✔️ Flag on ``add`` command added
🏁 Test for the research func
	[T]	Test the other funcs created

* ✔️ Better error handling for that
👉 TODO? More interaction for this command/flag

* ✔️ command ``new`` implemented to generated new target dirs
🏁 Tests passed

*  Added fallback to cmd.Help() by default

* ✔️ add

* ✔️ init

* ✔️ new
✅ fix init

* ✔️ purge

* ✔️ rm

* ✔️ root

* ✔️ set

* ✔️ start
👉 the rest can wait :(

* 👍 Small update to README.md

* messing

* Update documentation (#37)

*  Added fallback to cmd.Help() by default

* ✔️ add

* ✔️ init

* ✔️ new
✅ fix init

* ✔️ purge

* ✔️ rm

* ✔️ root

* ✔️ set

* ✔️ start
👉 the rest can wait :(

* 👍 Small update to README.md

* messing

* small fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChacaS0 ChacaS0

Labels
beta Stuff for/from the beta doc Operation on documentation enhancement Improvement of existing feature test stuff to do about testing (unit tests, live tests, etc) todo when it needs to be done website When it's about gh-pages or a website to/about TEMPest
Projects
None yet
Milestone
v0.2B
Development

No branches or pull requests
1 participant
@ChacaS0