Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add color palette #226

Merged
merged 1 commit into from
Jun 27, 2023
Merged

add color palette #226

merged 1 commit into from
Jun 27, 2023

Conversation

Lykhoyda
Copy link
Collaborator

@Lykhoyda Lykhoyda commented Jun 27, 2023

Closes #191

@Lykhoyda
Copy link
Collaborator Author

@Tbaut Some colors could still be hard coded as they are not from the primary color palette introduced in the design (I will handle it in the next issues dedicated to the update of the specific component).

@asnaith Please check if any element looks off after the colors update

@Lykhoyda Lykhoyda requested review from asnaith and Tbaut June 27, 2023 10:19
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you so much. Very clean already. I've been looking carefully at the buttons, the text fields, and most of what should have been impacted, but I let Andrew take a closer look to, I'm never too sure :)

@asnaith
Copy link
Member

asnaith commented Jun 27, 2023

This is a really nice improvement @Lykhoyda, I couldn't find anything that looked off.

The color has added a nice consistency and the depth on the multi/proxy badges really stands out now

@Tbaut Tbaut merged commit 580e4e3 into main Jun 27, 2023
@Tbaut Tbaut deleted the lykhoyda/add_color_pallets branch June 27, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate the color palette from new design
3 participants