Bug fix 189 balance #192
Merged
Bug fix 189 balance #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrisfenos
commented
Sep 25, 2018
chrisfenos
commented
- Balance is loaded async
- Ether - ERC20 abstracted to scripts directory for modularity
- Balance Reducer created to track tokens and balances
…into bugFix-189-balance
…this is triggered in recover wallet -> will allow the main page to have an accurate balance before the user needs to refresh.
…mount of tokens for that symbol based on the private key
… string of all the symbols we hold in our wallet to the api and return then entire price matrix
…eds to be refactored.
src/reducers/wallet/Balance.js
Outdated
| let quant = state.walletTokens[0][key[1]]; | ||
| let usdPrice = state.tokenConversions["ETH"].USD; | ||
| let total = quant*usdPrice; | ||
| return { ...state, initialBalance: total }; |
There was a problem hiding this comment.
This logic should happen outside of the reducer. Move it to the appropriate action
There was a problem hiding this comment.
@GregTheGreek done
|
|
||
| const ethers = require('ethers'); | ||
|
|
||
| const processAllTokenBalances = async (privateKey, dataSet) => { |
There was a problem hiding this comment.
this function has a lot of console.log()
There was a problem hiding this comment.
@GregTheGreek fixed
src/scripts/tokenBalances.js
Outdated
| key = Object.keys(dataSet[i]); | ||
| const contract = new ethers.Contract(key[1], ERC20ABI, provider); //key[1] is contract address | ||
| const tokenBalance = await contract.balanceOf(wallet.address); | ||
| key = Object.keys(dataSet[i]); |
GregTheGreek
requested changes
Sep 26, 2018
src/scripts/tokenBalances.js
Outdated
| const contract = new ethers.Contract(contractAdd, ERC20ABI, provider); | ||
| const tokenBalance = await contract.balanceOf(wallet.address); | ||
| const parsedTokenBalance = String(tokenBalance); | ||
| console.log('Token Balance', parsedTokenBalance); |
src/screens/main/portfolio/index.js
Outdated
| () => { | ||
| this.tokenBalanceLoop(); | ||
| }); | ||
| console.log('List refreshed'); |
There was a problem hiding this comment.
@GregTheGreek done
| tokenObj.symbol = dataSet[i].symbol; | ||
| if (dataSet[i].contractAddress === '') { | ||
| await this.getEthereumBalance(wallet.address) | ||
| .then((response) => { |
There was a problem hiding this comment.
@GregTheGreek done
GregTheGreek
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.