Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 Actors Amt update #978

Merged
merged 16 commits into from
Feb 3, 2021
Merged

v3 Actors Amt update #978

merged 16 commits into from
Feb 3, 2021

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Feb 2, 2021

Summary of changes
Changes introduced in this pull request:

Benchmark results

No features enabled (caching efficiency the same)

AMT bulk insert (no flush)
                        time:   [29.195 us 29.709 us 30.292 us]
                        change: [-1.2843% +0.8328% +2.8696%] (p = 0.44 > 0.05)
                        No change in performance detected.
Found 17 outliers among 100 measurements (17.00%)
  5 (5.00%) high mild
  12 (12.00%) high severe

AMT bulk insert with flushing and loading
                        time:   [592.92 us 602.70 us 614.00 us]
                        change: [-13.794% -11.543% -9.2613%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
  4 (4.00%) high mild
  9 (9.00%) high severe

AMT initialization from slice
                        time:   [85.129 us 86.236 us 87.617 us]
                        change: [-0.5285% +2.8561% +7.0129%] (p = 0.13 > 0.05)
                        No change in performance detected.
Found 13 outliers among 100 measurements (13.00%)
  11 (11.00%) high mild
  2 (2.00%) high severe

AMT for_each function   time:   [46.364 us 47.120 us 48.033 us]
                        change: [+20.836% +23.095% +25.721%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
  3 (3.00%) high mild
  7 (7.00%) high severe

Half of #959

Reference issue to close (if applicable)

Closes

Other information and links

ipld/amt/Cargo.toml Outdated Show resolved Hide resolved
ipld/amt/src/lib.rs Outdated Show resolved Hide resolved
ipld/amt/src/lib.rs Outdated Show resolved Hide resolved
@austinabell austinabell merged commit 931de22 into main Feb 3, 2021
@austinabell austinabell deleted the austin/amt branch February 3, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants