Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update BABE slot time calculation on start-up #1317

Closed
noot opened this issue Jan 20, 2021 · 2 comments · Fixed by #1344
Closed

update BABE slot time calculation on start-up #1317

noot opened this issue Jan 20, 2021 · 2 comments · Fixed by #1344
Assignees

Comments

@noot
Copy link
Contributor

noot commented Jan 20, 2021

Task summary

  • substrate doesn't use relative time currently (ie. babe.Service.getCurrentSlot can be unused)
  • when the node starts up, it should set the current slot as the slot based on non-relative time (unix time / slot duration)
@FlorianFranzen
Copy link
Contributor

FlorianFranzen commented Jan 20, 2021

I would say it does not use relative time yet, as it is still the plan to implemented it. For now there are a few open questions around joining the network using relative time (e.g. w3f/polkadot-spec#263) and current development is mainly focused on parachains, but we will get back to it future.

Therefore I would recommend disabling it instead of throwing it all away.

@noot
Copy link
Contributor Author

noot commented Jan 20, 2021

good to know, I'll update the issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants