Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go incompatible with JS #47

Closed
tobowers opened this issue Sep 24, 2019 · 5 comments
Closed

Go incompatible with JS #47

tobowers opened this issue Sep 24, 2019 · 5 comments

Comments

@tobowers
Copy link

Hi hi,

I noticed that Go cannot publish messages that JS receives when using elliptic keys. That's because Go inlines the public key into the peer ID. We already worked on this issue with just general connections, but it appears it's broken in PubSub additionally.

This PR: libp2p/js-peer-id#101 will allow the issue to be fixed and enable finishing up this TODO: https://github.com/libp2p/js-libp2p-pubsub/blob/master/src/message/sign.js#L76

@wemeetagain
Copy link
Member

Thanks for the heads up!

@GregTheGreek
Copy link
Member

@tobowers Let us know if there's anything you could use help with!

We identified a few issues surrounding message signing two weeks ago during the ETH2 interop, but we've been pretty heads down.

@tobowers
Copy link
Author

Great! Well - making good progress on the inlined keys. What else did you find?

@stale
Copy link

stale bot commented Nov 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale label Nov 10, 2019
@stale
Copy link

stale bot commented Nov 17, 2019

This issue or pull request has been automatically been closed due to inactivity.

@stale stale bot closed this as completed Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants