update penalty params for Merge #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
force-pushed
the
merge-penalties
branch
from
4ffd780
to
78040ac
Compare
protolambda
previously requested changes
Oct 29, 2021
| @@ -223,6 +245,62 @@ def compute_timestamp_at_slot(state: BeaconState, slot: Slot) -> uint64: | |||
| return uint64(state.genesis_time + slots_since_genesis * SECONDS_PER_SLOT) | |||
| ``` | |||
|
|
|||
| ### Beacon state accessors | |||
There was a problem hiding this comment.
Altair is frozen, but it might make sense to go for code-reuse anyway by not copying it over. That said, I'm also kind of happy we can easily extract a version of the spec that doesn't contain any legacy preset/config options, for new client implementations to join.
There was a problem hiding this comment.
by instead providing a config getter function -- e.g. get_inactivity_penalty_quotient(epoch) or something?
yeah, I see the argument on both sides ..
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
hwwhww
reviewed
Oct 30, 2021
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
This was referenced Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in EIP-2982, punitive penalty params will be adjusted upward to maximum security for the Merge.
(note, these were partially increased during Altair