Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CLI flags for v1 #4457

Merged
merged 34 commits into from
Aug 20, 2022
Merged

Rename CLI flags for v1 #4457

merged 34 commits into from
Aug 20, 2022

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain commented Aug 19, 2022 •
edited by dapplion
Loading

@dapplion dapplion mentioned this pull request Aug 20, 2022
Closed
4 tasks
dapplion
dapplion reviewed Aug 20, 2022
View reviewed changes
packages/cli/src/cmds/init/handler.ts
beaconNodeOptions.set({network: {discv5: {bindAddr: `/ip4/0.0.0.0/udp/${discoveryPort}`}}});
} else if (args.discoveryPort !== undefined) {
beaconNodeOptions.set({network: {discv5: {bindAddr: `/ip4/0.0.0.0/udp/${args.discoveryPort}`}}});
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled in packages/cli/src/options/beaconNodeOptions/network.ts now

@dapplion dapplion changed the title cli flag overhaul Rename CLI flags for v1 Aug 20, 2022
@dapplion dapplion marked this pull request as ready for review August 20, 2022 10:15
@dapplion dapplion requested a review from a team as a code owner August 20, 2022 10:15
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2022 •
edited
Loading

⚠️ Performance Alert ⚠️

Possible performance regression was detected for some benchmarks.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold.

Benchmark suite Current: 50dea9a Previous: 2a6929b Ratio
enrSubnets - fastDeserialize 4 bits 1.2480 us/op 346.00 ns/op 3.61
Full benchmark results
Benchmark suite Current: 50dea9a Previous: 2a6929b Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.9471 ms/op 1.5245 ms/op 1.93
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 91.478 us/op 63.193 us/op 1.45
BLS verify - blst-native 2.2797 ms/op 2.1686 ms/op 1.05
BLS verifyMultipleSignatures 3 - blst-native 4.8867 ms/op 4.4735 ms/op 1.09
BLS verifyMultipleSignatures 8 - blst-native 10.410 ms/op 9.6766 ms/op 1.08
BLS verifyMultipleSignatures 32 - blst-native 36.477 ms/op 35.135 ms/op 1.04
BLS aggregatePubkeys 32 - blst-native 51.334 us/op 46.519 us/op 1.10
BLS aggregatePubkeys 128 - blst-native 191.34 us/op 182.54 us/op 1.05
getAttestationsForBlock 218.41 ms/op 140.45 ms/op 1.56
isKnown best case - 1 super set check 499.00 ns/op 492.00 ns/op 1.01
isKnown normal case - 2 super set checks 530.00 ns/op 481.00 ns/op 1.10
isKnown worse case - 16 super set checks 486.00 ns/op 479.00 ns/op 1.01
CheckpointStateCache - add get delete 10.848 us/op 8.6120 us/op 1.26
validate gossip signedAggregateAndProof - struct 5.3141 ms/op 5.0221 ms/op 1.06
validate gossip attestation - struct 2.6664 ms/op 2.3740 ms/op 1.12
altair verifyImport mainnet_s3766816:31 5.8742 s/op 4.7507 s/op 1.24
pickEth1Vote - no votes 3.0380 ms/op 2.0178 ms/op 1.51
pickEth1Vote - max votes 31.494 ms/op 19.049 ms/op 1.65
pickEth1Vote - Eth1Data hashTreeRoot value x2048 17.329 ms/op 12.169 ms/op 1.42
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 27.631 ms/op 21.305 ms/op 1.30
pickEth1Vote - Eth1Data fastSerialize value x2048 1.9727 ms/op 1.3853 ms/op 1.42
pickEth1Vote - Eth1Data fastSerialize tree x2048 22.529 ms/op 11.272 ms/op 2.00
bytes32 toHexString 1.5140 us/op 900.00 ns/op 1.68
bytes32 Buffer.toString(hex) 950.00 ns/op 713.00 ns/op 1.33
bytes32 Buffer.toString(hex) from Uint8Array 1.2820 us/op 946.00 ns/op 1.36
bytes32 Buffer.toString(hex) + 0x 965.00 ns/op 710.00 ns/op 1.36
Object access 1 prop 0.51300 ns/op 0.32900 ns/op 1.56
Map access 1 prop 0.36700 ns/op 0.35400 ns/op 1.04
Object get x1000 17.104 ns/op 11.151 ns/op 1.53
Map get x1000 1.0790 ns/op 0.99500 ns/op 1.08
Object set x1000 146.31 ns/op 63.735 ns/op 2.30
Map set x1000 99.165 ns/op 43.051 ns/op 2.30
Return object 10000 times 0.44270 ns/op 0.43530 ns/op 1.02
Throw Error 10000 times 7.3651 us/op 5.9415 us/op 1.24
enrSubnets - fastDeserialize 64 bits 3.6540 us/op 2.4520 us/op 1.49
enrSubnets - ssz BitVector 64 bits 982.00 ns/op 733.00 ns/op 1.34
enrSubnets - fastDeserialize 4 bits 1.2480 us/op 346.00 ns/op 3.61
enrSubnets - ssz BitVector 4 bits 1.4120 us/op 739.00 ns/op 1.91
prioritizePeers score -10:0 att 32-0.1 sync 2-0 138.51 us/op 77.994 us/op 1.78
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 161.36 us/op 120.51 us/op 1.34
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 274.96 us/op 192.27 us/op 1.43
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 684.57 us/op 333.48 us/op 2.05
prioritizePeers score 0:0 att 64-1 sync 4-1 651.07 us/op 406.37 us/op 1.60
RateTracker 1000000 limit, 1 obj count per request 211.93 ns/op 175.90 ns/op 1.20
RateTracker 1000000 limit, 2 obj count per request 163.96 ns/op 128.47 ns/op 1.28
RateTracker 1000000 limit, 4 obj count per request 131.33 ns/op 105.73 ns/op 1.24
RateTracker 1000000 limit, 8 obj count per request 119.67 ns/op 93.291 ns/op 1.28
RateTracker with prune 5.5890 us/op 3.6090 us/op 1.55
array of 16000 items push then shift 5.7598 us/op 51.571 us/op 0.11
LinkedList of 16000 items push then shift 32.078 ns/op 14.883 ns/op 2.16
array of 16000 items push then pop 269.39 ns/op 186.90 ns/op 1.44
LinkedList of 16000 items push then pop 26.136 ns/op 13.921 ns/op 1.88
array of 24000 items push then shift 9.2839 us/op 77.362 us/op 0.12
LinkedList of 24000 items push then shift 32.885 ns/op 17.843 ns/op 1.84
array of 24000 items push then pop 259.70 ns/op 197.39 ns/op 1.32
LinkedList of 24000 items push then pop 26.680 ns/op 14.711 ns/op 1.81
intersect bitArray bitLen 8 12.831 ns/op 10.817 ns/op 1.19
intersect array and set length 8 184.57 ns/op 124.32 ns/op 1.48
intersect bitArray bitLen 128 72.796 ns/op 57.013 ns/op 1.28
intersect array and set length 128 2.5062 us/op 1.6941 us/op 1.48
Buffer.concat 32 items 2.4950 ns/op 1.8360 ns/op 1.36
pass gossip attestations to forkchoice per slot 8.0801 ms/op 5.3038 ms/op 1.52
computeDeltas 6.1253 ms/op 3.9928 ms/op 1.53
computeProposerBoostScoreFromBalances 919.06 us/op 804.15 us/op 1.14
altair processAttestation - 250000 vs - 7PWei normalcase 6.5255 ms/op 3.3781 ms/op 1.93
altair processAttestation - 250000 vs - 7PWei worstcase 9.2229 ms/op 6.0948 ms/op 1.51
altair processAttestation - setStatus - 1/6 committees join 263.07 us/op 174.97 us/op 1.50
altair processAttestation - setStatus - 1/3 committees join 508.11 us/op 341.51 us/op 1.49
altair processAttestation - setStatus - 1/2 committees join 709.08 us/op 487.10 us/op 1.46
altair processAttestation - setStatus - 2/3 committees join 915.49 us/op 636.35 us/op 1.44
altair processAttestation - setStatus - 4/5 committees join 1.3821 ms/op 890.66 us/op 1.55
altair processAttestation - setStatus - 100% committees join 1.6692 ms/op 1.0829 ms/op 1.54
altair processBlock - 250000 vs - 7PWei normalcase 39.528 ms/op 24.967 ms/op 1.58
altair processBlock - 250000 vs - 7PWei normalcase hashState 44.670 ms/op 36.522 ms/op 1.22
altair processBlock - 250000 vs - 7PWei worstcase 118.91 ms/op 93.761 ms/op 1.27
altair processBlock - 250000 vs - 7PWei worstcase hashState 137.23 ms/op 97.962 ms/op 1.40
phase0 processBlock - 250000 vs - 7PWei normalcase 4.5118 ms/op 3.6040 ms/op 1.25
phase0 processBlock - 250000 vs - 7PWei worstcase 58.912 ms/op 51.028 ms/op 1.15
altair processEth1Data - 250000 vs - 7PWei normalcase 1.4611 ms/op 656.39 us/op 2.23
Tree 40 250000 create 1.0211 s/op 696.43 ms/op 1.47
Tree 40 250000 get(125000) 339.47 ns/op 225.58 ns/op 1.50
Tree 40 250000 set(125000) 3.2675 us/op 1.9027 us/op 1.72
Tree 40 250000 toArray() 51.295 ms/op 25.869 ms/op 1.98
Tree 40 250000 iterate all - toArray() + loop 44.061 ms/op 28.067 ms/op 1.57
Tree 40 250000 iterate all - get(i) 149.70 ms/op 105.04 ms/op 1.43
MutableVector 250000 create 16.704 ms/op 18.050 ms/op 0.93
MutableVector 250000 get(125000) 14.754 ns/op 12.017 ns/op 1.23
MutableVector 250000 set(125000) 844.41 ns/op 416.58 ns/op 2.03
MutableVector 250000 toArray() 8.1727 ms/op 5.4315 ms/op 1.50
MutableVector 250000 iterate all - toArray() + loop 8.3803 ms/op 5.5249 ms/op 1.52
MutableVector 250000 iterate all - get(i) 3.6506 ms/op 2.7011 ms/op 1.35
Array 250000 create 7.8582 ms/op 5.2677 ms/op 1.49
Array 250000 clone - spread 3.5606 ms/op 2.3400 ms/op 1.52
Array 250000 get(125000) 1.5020 ns/op 1.2050 ns/op 1.25
Array 250000 set(125000) 1.6490 ns/op 1.1940 ns/op 1.38
Array 250000 iterate all - loop 149.61 us/op 152.20 us/op 0.98
effectiveBalanceIncrements clone Uint8Array 300000 427.75 us/op 34.513 us/op 12.39
effectiveBalanceIncrements clone MutableVector 300000 826.00 ns/op 705.00 ns/op 1.17
effectiveBalanceIncrements rw all Uint8Array 300000 301.50 us/op 247.38 us/op 1.22
effectiveBalanceIncrements rw all MutableVector 300000 236.71 ms/op 130.24 ms/op 1.82
phase0 afterProcessEpoch - 250000 vs - 7PWei 223.26 ms/op 206.59 ms/op 1.08
phase0 beforeProcessEpoch - 250000 vs - 7PWei 89.175 ms/op 112.40 ms/op 0.79
altair processEpoch - mainnet_e81889 704.36 ms/op 646.23 ms/op 1.09
mainnet_e81889 - altair beforeProcessEpoch 177.18 ms/op 168.02 ms/op 1.05
mainnet_e81889 - altair processJustificationAndFinalization 73.672 us/op 24.668 us/op 2.99
mainnet_e81889 - altair processInactivityUpdates 13.739 ms/op 8.5621 ms/op 1.60
mainnet_e81889 - altair processRewardsAndPenalties 116.68 ms/op 155.88 ms/op 0.75
mainnet_e81889 - altair processRegistryUpdates 16.085 us/op 5.4330 us/op 2.96
mainnet_e81889 - altair processSlashings 4.1900 us/op 1.1170 us/op 3.75
mainnet_e81889 - altair processEth1DataReset 4.2800 us/op 1.2600 us/op 3.40
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.6847 ms/op 2.3195 ms/op 1.16
mainnet_e81889 - altair processSlashingsReset 24.010 us/op 9.0370 us/op 2.66
mainnet_e81889 - altair processRandaoMixesReset 24.613 us/op 6.9000 us/op 3.57
mainnet_e81889 - altair processHistoricalRootsUpdate 4.8600 us/op 1.1110 us/op 4.37
mainnet_e81889 - altair processParticipationFlagUpdates 13.807 us/op 4.0640 us/op 3.40
mainnet_e81889 - altair processSyncCommitteeUpdates 3.5120 us/op 931.00 ns/op 3.77
mainnet_e81889 - altair afterProcessEpoch 223.91 ms/op 199.10 ms/op 1.12
phase0 processEpoch - mainnet_e58758 650.38 ms/op 614.40 ms/op 1.06
mainnet_e58758 - phase0 beforeProcessEpoch 303.66 ms/op 234.00 ms/op 1.30
mainnet_e58758 - phase0 processJustificationAndFinalization 68.187 us/op 28.788 us/op 2.37
mainnet_e58758 - phase0 processRewardsAndPenalties 172.83 ms/op 129.24 ms/op 1.34
mainnet_e58758 - phase0 processRegistryUpdates 33.917 us/op 14.226 us/op 2.38
mainnet_e58758 - phase0 processSlashings 3.9060 us/op 1.0860 us/op 3.60
mainnet_e58758 - phase0 processEth1DataReset 3.7380 us/op 1.3150 us/op 2.84
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.0599 ms/op 1.9476 ms/op 1.06
mainnet_e58758 - phase0 processSlashingsReset 20.116 us/op 5.0500 us/op 3.98
mainnet_e58758 - phase0 processRandaoMixesReset 25.169 us/op 8.0330 us/op 3.13
mainnet_e58758 - phase0 processHistoricalRootsUpdate 5.1900 us/op 1.0580 us/op 4.91
mainnet_e58758 - phase0 processParticipationRecordUpdates 25.514 us/op 6.6870 us/op 3.82
mainnet_e58758 - phase0 afterProcessEpoch 179.06 ms/op 164.26 ms/op 1.09
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.5138 ms/op 2.0689 ms/op 1.22
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.7953 ms/op 2.3892 ms/op 1.17
altair processInactivityUpdates - 250000 normalcase 58.405 ms/op 52.379 ms/op 1.12
altair processInactivityUpdates - 250000 worstcase 72.251 ms/op 57.565 ms/op 1.26
phase0 processRegistryUpdates - 250000 normalcase 30.758 us/op 11.379 us/op 2.70
phase0 processRegistryUpdates - 250000 badcase_full_deposits 526.47 us/op 542.41 us/op 0.97
phase0 processRegistryUpdates - 250000 worstcase 0.5 272.93 ms/op 225.12 ms/op 1.21
altair processRewardsAndPenalties - 250000 normalcase 145.17 ms/op 132.85 ms/op 1.09
altair processRewardsAndPenalties - 250000 worstcase 105.04 ms/op 140.94 ms/op 0.75
phase0 getAttestationDeltas - 250000 normalcase 15.899 ms/op 11.619 ms/op 1.37
phase0 getAttestationDeltas - 250000 worstcase 15.608 ms/op 11.667 ms/op 1.34
phase0 processSlashings - 250000 worstcase 6.9327 ms/op 5.3269 ms/op 1.30
altair processSyncCommitteeUpdates - 250000 373.54 ms/op 293.35 ms/op 1.27
BeaconState.hashTreeRoot - No change 643.00 ns/op 515.00 ns/op 1.25
BeaconState.hashTreeRoot - 1 full validator 79.545 us/op 70.562 us/op 1.13
BeaconState.hashTreeRoot - 32 full validator 811.60 us/op 817.38 us/op 0.99
BeaconState.hashTreeRoot - 512 full validator 13.425 ms/op 6.9101 ms/op 1.94
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 104.30 us/op 98.847 us/op 1.06
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.5763 ms/op 1.2697 ms/op 1.24
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 20.216 ms/op 16.788 ms/op 1.20
BeaconState.hashTreeRoot - 1 balances 84.970 us/op 68.629 us/op 1.24
BeaconState.hashTreeRoot - 32 balances 748.90 us/op 730.24 us/op 1.03
BeaconState.hashTreeRoot - 512 balances 7.2590 ms/op 6.1734 ms/op 1.18
BeaconState.hashTreeRoot - 250000 balances 124.26 ms/op 101.55 ms/op 1.22
aggregationBits - 2048 els - zipIndexesInBitList 45.959 us/op 24.645 us/op 1.86
regular array get 100000 times 63.558 us/op 65.225 us/op 0.97
wrappedArray get 100000 times 61.885 us/op 60.576 us/op 1.02
arrayWithProxy get 100000 times 38.850 ms/op 32.241 ms/op 1.20
ssz.Root.equals 671.00 ns/op 543.00 ns/op 1.24
byteArrayEquals 634.00 ns/op 455.00 ns/op 1.39
shuffle list - 16384 els 12.829 ms/op 11.536 ms/op 1.11
shuffle list - 250000 els 190.66 ms/op 169.06 ms/op 1.13
processSlot - 1 slots 19.554 us/op 12.574 us/op 1.56
processSlot - 32 slots 2.5504 ms/op 1.8759 ms/op 1.36
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 714.17 us/op 309.63 us/op 2.31
getCommitteeAssignments - req 1 vs - 250000 vc 5.8883 ms/op 5.4665 ms/op 1.08
getCommitteeAssignments - req 100 vs - 250000 vc 8.5430 ms/op 8.0717 ms/op 1.06
getCommitteeAssignments - req 1000 vs - 250000 vc 8.8939 ms/op 8.7036 ms/op 1.02
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 10.340 ns/op 7.9300 ns/op 1.30
state getBlockRootAtSlot - 250000 vs - 7PWei 1.4716 us/op 972.61 ns/op 1.51
computeProposers - vc 250000 21.531 ms/op 17.347 ms/op 1.24
computeEpochShuffling - vc 250000 185.73 ms/op 173.41 ms/op 1.07
getNextSyncCommittee - vc 250000 354.64 ms/op 287.50 ms/op 1.23

by benchmarkbot/action

@wemeetagain @g11tech
Rename rootDir to dataDir
6d859e9
@wemeetagain @g11tech
Refactor initializeOptionsAndConfig
544ecf5
@wemeetagain @g11tech
Remove old peerstore migration
14fda92
@wemeetagain @g11tech
Fix rootDir
7bdd9fa
@wemeetagain @g11tech
Rename metrics.enabled to metrics
a60acc0
@wemeetagain @g11tech
Rename api.rest to rest
541a532
@wemeetagain @g11tech
Rename chain.defaultFeeRecipient to suggestedFeeRecipient
d9a3477
@wemeetagain @g11tech
Rename network.discv5.enabled to discv5
fc07e7e
@wemeetagain @g11tech
Set many network flags as hidden
620f7b6
@wemeetagain @g11tech
Fix rest rename
dc90c31
@wemeetagain @g11tech
Change rest options order
f6ce298
@wemeetagain @g11tech
Remove rest alias
39e0206
@wemeetagain @g11tech
Rename builder.enabled to builder
1f13172
@wemeetagain @g11tech
More suggestedFeeRecipient
df8a1b5
@wemeetagain @g11tech
Hide most chain options
7f48718
@wemeetagain @g11tech
Rename eth1.enabled to eth1
30aa361
@wemeetagain @g11tech
Remove eth1.providerUrl
81a07d3
@wemeetagain @g11tech
Hide eth1.depositContractDeployBlock
51a6b37
@wemeetagain @g11tech
More eth1.enabled
fea9b9a
@wemeetagain @g11tech
More rest.enabled
bd815ff
@wemeetagain @g11tech
More rest.namespace
2cc2085
@wemeetagain @g11tech
More rest.address
e1b3865
@wemeetagain @g11tech
More rest.port
447f53b
@wemeetagain @g11tech
More suggestedFeeRecipient
f076ee1
@g11tech g11tech enabled auto-merge (squash) August 20, 2022 11:49
g11tech
g11tech approved these changes Aug 20, 2022
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! lets go 🚀

dapplion
dapplion approved these changes Aug 20, 2022
View reviewed changes
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@dapplion
Copy link
Contributor

@philknows Please could you write a migration guide for the flags changed when available?

@g11tech g11tech merged commit b2d6a55 into unstable Aug 20, 2022
@g11tech g11tech deleted the cayman/cli-flag-overhaul branch August 20, 2022 12:09
@q9f q9f added the meta-breaking-change Introduces breaking changes to DB, Validator, Beacon Node, or CLI interfaces. Handle with care! label Aug 20, 2022
@philknows
Copy link
Member

@philknows Please could you write a migration guide for the flags changed when available?

Adding this as part of the v1.0.0 announcement.

This was referenced Aug 27, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
meta-breaking-change Introduces breaking changes to DB, Validator, Beacon Node, or CLI interfaces. Handle with care!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wemeetagain @dapplion @philknows @g11tech @q9f