-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: assert eslintrc rules are sorted #5567
Conversation
f1576bd
to
9082fd4
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
9082fd4
to
8717914
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just a hint from GPT-4
It's important to note that the order of rules in eslint configurations can matter. For example, if you're using a plugin that extends eslint's functionality and there's a conflict between two rules, the rule that appears last in the configuration will take precedence. So, even if the two configurations have the same rules, if they're in a different order, they might not function identically.
It does not seem to matter in our case as there are no lint errors.
🎉 This PR is included in v1.9.0 🎉 |
Motivation
Description
Add CI step to ensure eslintrc rules are sorted