Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch idle_connections back to a LIFO queue #1

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Switch idle_connections back to a LIFO queue #1

merged 2 commits into from
Oct 8, 2019

Conversation

Changaco
Copy link
Owner

@Changaco Changaco commented Oct 7, 2019

I used a FIFO queue so that the getconn method would close old connections automatically, but doing this can result in more connections being kept open than necessary, thus defeating the purpose of the idle_timeout attribute.

I used a FIFO queue so that the `getconn` method would close old connections automatically, but doing this can result in more connections being kept open than necessary, thus defeating the purpose of the `idle_timeout` attribute.
@Changaco Changaco merged commit 71bd372 into master Oct 8, 2019
@Changaco Changaco deleted the lifo branch October 8, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant