Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration to fulfillmet order api (2023-04) #97

Conversation

clericuzzi
Copy link
Contributor

No description provided.

@rjdavis3
Copy link
Member

@clericuzzi clericuzzi force-pushed the feature/CA-22228/shopify-push-fulfillments-service-migration branch 2 times, most recently from 67922fc to 8fd1b60 Compare February 15, 2023 13:37
@clericuzzi clericuzzi force-pushed the feature/CA-22228/shopify-push-fulfillments-service-migration branch from 8fd1b60 to 18d0903 Compare February 15, 2023 13:40
Copy link
Member

@rjdavis3 rjdavis3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clericuzzi nice work! Most of my feedback is around what we went over with @ryankazokas

Let me know if you have any questions.

src/main/java/com/shopify/ShopifySdk.java Outdated Show resolved Hide resolved
src/main/java/com/shopify/ShopifySdk.java Outdated Show resolved Hide resolved
src/main/java/com/shopify/ShopifySdk.java Outdated Show resolved Hide resolved
src/main/java/com/shopify/ShopifySdk.java Show resolved Hide resolved
src/main/java/com/shopify/ShopifySdk.java Outdated Show resolved Hide resolved
src/main/java/com/shopify/ShopifySdk.java Outdated Show resolved Hide resolved
src/main/java/com/shopify/ShopifySdk.java Show resolved Hide resolved
@clericuzzi clericuzzi force-pushed the feature/CA-22228/shopify-push-fulfillments-service-migration branch from e5af923 to a90fef8 Compare February 17, 2023 15:51
Copy link
Member

@ryankazokas ryankazokas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clericuzzi just one more control flow thing around exceptions in the mapping. I'm going to approve this but please make sure you make those changes or ask if you have questions.

@clericuzzi clericuzzi merged commit 9714f59 into develop Feb 24, 2023
@clericuzzi clericuzzi deleted the feature/CA-22228/shopify-push-fulfillments-service-migration branch February 24, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants