-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migration to fulfillmet order api (2023-04) #97
migration to fulfillmet order api (2023-04) #97
Conversation
67922fc
to
8fd1b60
Compare
8fd1b60
to
18d0903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clericuzzi nice work! Most of my feedback is around what we went over with @ryankazokas
Let me know if you have any questions.
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyAssignedLocation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyDeliveryMethod.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyDeliveryMethod.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyDestination.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyDestination.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyDestination.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyFulfillmentOrder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyFulfillmentOrder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyFulfillmentOrderPayload.java
Outdated
Show resolved
Hide resolved
src/main/java/com/shopify/model/fulfillmentOrderApi/ShopifyInternationalDuty.java
Outdated
Show resolved
Hide resolved
e5af923
to
a90fef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clericuzzi just one more control flow thing around exceptions in the mapping. I'm going to approve this but please make sure you make those changes or ask if you have questions.
No description provided.