Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better supervisor config #184

Merged
merged 2 commits into from
May 24, 2017

Conversation

amoffat
Copy link
Contributor

@amoffat amoffat commented May 24, 2017

let's try this again #146, now that we have a democracy back

now that we have http://chaosthebot.com:8081/ for logs, let's make the log files a little more manageable

also, we'll lean on supervisor for restarting things

@chaosbot chaosbot merged commit bb16740 into Chaosthebot:master May 24, 2017
@amoffat amoffat deleted the better-supervisor-config branch May 24, 2017 19:35
@rhengles
Copy link
Member

What happened that this was merged immediately?

@amoffat
Copy link
Contributor Author

amoffat commented May 24, 2017

@rhengles I can tell you why it merged right away, but I can't tell you why the vote threshold was only 1.0. It merged due to a bug that hasn't been patched yet, where if a downstream branch sits for longer than the voting window, before a PR is opened, then a PR is opened, chaos thinks its ready to be approved. Needs to be patched ASAP

@rudehn
Copy link
Contributor

rudehn commented May 24, 2017

oh that's bad

@hongaar
Copy link
Member

hongaar commented May 24, 2017

@amoffat Vote threshold was only 1.0 because at the time this was merged, #152 was not merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants