-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voting threshold too high due to misleading github api #194
Conversation
💯 Was in the middle of writing a similar change. Kudos. |
I feel that 14.4 is a bit too high, but 3.54 is way too low and easy. Take this PR as an example: only 15 minutes old and already 11 👍 . So the bar could be easily raised! Clickbait PR titles FTW! Although on the other hand ... chaos ... |
@hongaar definitely a balancing act |
Machine learning? |
I would bump the percentage to 5%. That would require 6 votes. Not too low but not too high either |
@rudehn sounds good. let's do it in a new PR after this one lands, just so I don't reset the voting window |
I think the threshold as it's implemented now (minimum difference between + and -) should be set to 1 again, and instead there should be a minimum amount of votes needed (which could also be called a threshold confusingly and again could be based on stargazers, followers, whatever). That's truer to democracy I think. |
🙆♀️ PR passed with a vote of 23 for and 0 against, with a weighted total of 23.0 and a threshold of 14.7. See merge-commit 4db36dc for more details. |
At the Chaos project, we have very high standards. |
haha, hi @phil-r |
hi @viktorsec 👋 |
Could use a push to get this over the 14 vote threshold. But then the threshold should be down to 3.54