Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting threshold too high due to misleading github api #194

Merged
merged 2 commits into from
May 24, 2017

Conversation

amoffat
Copy link
Contributor

@amoffat amoffat commented May 24, 2017

Could use a push to get this over the 14 vote threshold. But then the threshold should be down to 3.54

@dehodson
Copy link
Contributor

💯 Was in the middle of writing a similar change. Kudos.

@hongaar
Copy link
Member

hongaar commented May 24, 2017

I feel that 14.4 is a bit too high, but 3.54 is way too low and easy. Take this PR as an example: only 15 minutes old and already 11 👍 . So the bar could be easily raised! Clickbait PR titles FTW!

Although on the other hand ... chaos ...

@amoffat
Copy link
Contributor Author

amoffat commented May 24, 2017

@hongaar definitely a balancing act

@hongaar
Copy link
Member

hongaar commented May 24, 2017

Machine learning?

@hongaar hongaar mentioned this pull request May 24, 2017
@rudehn
Copy link
Contributor

rudehn commented May 24, 2017

I would bump the percentage to 5%. That would require 6 votes. Not too low but not too high either

@amoffat
Copy link
Contributor Author

amoffat commented May 24, 2017

@rudehn sounds good. let's do it in a new PR after this one lands, just so I don't reset the voting window

@hongaar
Copy link
Member

hongaar commented May 24, 2017

I think the threshold as it's implemented now (minimum difference between + and -) should be set to 1 again, and instead there should be a minimum amount of votes needed (which could also be called a threshold confusingly and again could be based on stargazers, followers, whatever). That's truer to democracy I think.

@chaosbot
Copy link
Collaborator

🙆‍♀️ PR passed with a vote of 23 for and 0 against, with a weighted total of 23.0 and a threshold of 14.7.

See merge-commit 4db36dc for more details.

@chaosbot chaosbot merged commit 4db36dc into Chaosthebot:master May 24, 2017
@phil-r
Copy link
Member

phil-r commented May 24, 2017

Something went wrong:
image

@dehodson
Copy link
Contributor

At the Chaos project, we have very high standards.

@phil-r
Copy link
Member

phil-r commented May 24, 2017

Everything is fine now 😌
image

@viktorsec
Copy link
Contributor

haha, hi @phil-r

@phil-r
Copy link
Member

phil-r commented May 24, 2017

hi @viktorsec 👋

@amoffat amoffat deleted the lower-voting-threshold branch May 24, 2017 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants