HOTFIX - vote spam #523
Merged
HOTFIX - vote spam #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swizz
approved these changes
Jun 5, 2017
|
👍 |
andrewda
approved these changes
Jun 5, 2017
|
✅ PR passed with a vote of 11 for and 0 against, a weighted total of 10.5 and a threshold of 6.2, and a current meritocracy review. See merge-commit f2a2130 for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix to help stop the vote spam we are seeing. Here's how it works.
The previous problem was that when identifying new commands, we didn't check if it was already in the inactive commands list.
What does this PR solve? Well it won't re-add commands to the db to be run. HOWEVER it won't solve the problem if there is an issue removing commands from the ActiveCommand table.
Either way, this check needs to be in.
Also, my apologies for the goof. I thought I had tested pretty well but something must have slipped through the cracks.