Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3.0 - Xcode 8 Beta 4 #1288

Closed
wants to merge 6 commits into from
Closed

Conversation

acegreen
Copy link

@acegreen acegreen commented Aug 3, 2016

Conforms To Xcode 8 Beta 4

@liuxuan30
Copy link
Member

liuxuan30 commented Aug 4, 2016

@acegreen Thanks for contributing!
However... first, please do not merge into master.
second, please pull and rebase on current swift 3.0 branch, I see this PR contains old commits (like mine), this is not normal.. Ideally, only ' Conforms To Xcode 8 Beta 4' should be presented.

@acegreen
Copy link
Author

acegreen commented Aug 4, 2016

@liuxuan30 merge into master is Github Desktop default even when you are on a different branch and is the reason there are old commits included in this PR. I'm actually fedup with Github Desktop

@acegreen acegreen closed this Aug 4, 2016
@liuxuan30
Copy link
Member

liuxuan30 commented Aug 4, 2016

@acegreen I'm sorry but I don't mean to hurt you your feeling but.. we have to follow some rules and once you master it it's very easy.
But you have to merge into swift 3.0 branch..

@acegreen
Copy link
Author

acegreen commented Aug 4, 2016

You don't hurt my feeling :) Github Desktop is truly a pain in the A**!! Moved to PR #1290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants