Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate Chart v3 code in master to swift 2.3 syntax #1388

Merged
merged 128 commits into from
Sep 1, 2016
Merged

migrate Chart v3 code in master to swift 2.3 syntax #1388

merged 128 commits into from
Sep 1, 2016

Conversation

liuxuan30
Copy link
Member

migrate Chart v3 code in master to swift 2.3 syntax

liuxuan30 and others added 30 commits July 1, 2016 09:36
@liuxuan30
update iso-snapshot-test-case to master to have the fix for now
0ef4220 
hopefully this will get travis working
@liuxuan30
Merge pull request ChartsOrg#1202 from liuxuan30/fixTravis
c5c442b 
update iso-snapshot-test-case to master to have the fix for now
@liuxuan30
upgrade carthage to 0.17.1
3197e7a
@liuxuan30
use master commit for iso-snapshot-test-case for now. once the fix is…
a72a43a 
… tagged we could change to the new version
@liuxuan30
change Rakefile, comment out tvOS because no FBSnapshotTestCase
31e9cff
@liuxuan30
Merge pull request ChartsOrg#1203 from liuxuan30/fixTravis
1b60553 
upgrade carthage, resolve test failure config
@VincentSit
Add missing imports for iOS 7 support
7eb5810
@VincentSit
Update ChartSelectionDetail.swift
3b31396
@AntiMoron
BUGFIX: fix infinite recursive call of getXIndex(_:)
098b961
@liuxuan30
Merge pull request ChartsOrg#1205 from VincentSit/patch-1
69998e0 
Add missing imports for iOS 7 support
@liuxuan30
Merge pull request ChartsOrg#1213 from AntiMoron/master
a7155c6 
BUGFIX: fix infinite recursive call of getXIndex(_:)
@liuxuan30
for ChartsOrg#1208, seems drawBarShadowEnabled should be false by def…
4d08068 
…ault
@liuxuan30
1. update ios-snapshot-test-case to 2.1.2
3734cc7 
2. remove brew upgrade carthage, because travis saying
@liuxuan30
Merge pull request ChartsOrg#1249 from liuxuan30/fixTravis
2efba1d 
remove brew upgrade carthage for travis and update ios-snapshot-test-case to 2.1.2
@liuxuan30
improve descriptions to warn users how to use setVisibleRange APIs
eadefab
@chris-gunawardena
Typo fix
d432396
@pmairoldi
Merge pull request ChartsOrg#1264 from chris-gunawardena/patch-1
8aab7b1 
Typo fix,  our of range => out of range
@liuxuan30
upgrade Realm to 1.0.2
6d91f61
@liuxuan30
update Realm pod spec to 1.0.2
d8e60fe
@liuxuan30
Merge pull request ChartsOrg#1270 from liuxuan30/Realm1.0.2
8b7b589 
support Realm 1.0.2
@liuxuan30
fix pod spec typo
6b29503
@liuxuan30
Merge pull request ChartsOrg#1271 from liuxuan30/master
4d35b2f 
fix Realm pod spec typo
@danielgindi
Work on x-values instead of x-indices (free for all :-)
3dbd57b
@danielgindi
Merge branch 'x-indices' into v3
6af7421 
* x-indices:
  Work on x-values instead of x-indices (free for all :-)
@danielgindi
Improvement for pie slice spacing calculation
3a0f638
@danielgindi
Example improvements
141128c
@danielgindi
Docs improvements
d0e05d8
@danielgindi
Major work on highlights
f49ef5f
@danielgindi
ChartMarker is now a protocol, and we have ChartMarkerView/Image helpers
2f00975
@danielgindi
Improvements regarding irrelevant inherited methods
761ca85
danielgindi and others added 26 commits August 14, 2016 10:16
@danielgindi
Fix dataset update in Dual line chart demo (Fixes ChartsOrg#1250)
e628b7a
@danielgindi
Merge pull request ChartsOrg#1226 from liuxuan30/turnOffBarShadow
a8cf54a 
for ChartsOrg#1208, seems drawBarShadowEnabled should be false by default
@danielgindi
Add half line width to clipping rect of grid/limit lines (Fixes Chart…
c05fbd8 
…sOrg#1204)
@danielgindi
Simplified legend entries configuration. Option to style dataset form.
6f51a55 
(Closes ChartsOrg#1282)
@danielgindi
Added feature for dashing legend line forms
e01c1be
@danielgindi
Change default formLineWidth to match the default on MPAndroidChart
fadea4d
@danielgindi
neededWidth should be enough here. formSize has no meaning globally.
5e53bf3 
If more offset is needed - use extraOffsets, or adjust the maxSizePercent).
@danielgindi
Renamed those classes too. Cleaner now. Should be too breaking...
3b459cc 
As with swift's minimal syntax - the chance of anyone referencing
  those by name is very low.
On ObjC, the names stayed the same, for namespacing.
@danielgindi
Take care of edge cases when calculating intervals (labelCount == 0)
d7769e6
@danielgindi
autoScaleMinMax is working again (Fixes ChartsOrg#1209)
ee4de2b
@danielgindi
Minor refactoring (Closes ChartsOrg#1187)
cbd7bf7 
Sorry, un-mergable to `master`...
@danielgindi
Fixed reversed condition from cbd7bf7
22711d6
@danielgindi
It's clearer this way
337fdea
@danielgindi
Fill before stroke - because the fill may cover half of a thick stroke
27930d9 
(Closes ChartsOrg#982)
@danielgindi
Added those new classes to tvOS/macOS targets
c78d35a
@danielgindi
Migrated viewFromXib to macOS
576b5c0
@danielgindi
Call print under Swift namespace, due to Cocoa ambiguity in NSView
03c2700
@danielgindi
Migrated macOS demos to Charts 3.0
2e117e3
@danielgindi
Use an optional for _displayLink (Fixes ChartsOrg#1336)
cee0c80 
_displayLink might not have been created, i.e. in Interface Builder context.
@danielgindi
Corrected LineChartRenderer cubicFill x range
3ab9b4e
@danielgindi
Fixed horizontal cubic calculation bug introduced when removing x-index
6f969aa
@danielgindi
Avoid using deprecated property in demo
6f49bd2
@danielgindi
Updated test screenshots
197245f
@danielgindi
Animating the wrong axis for the starting point
5e020a8
@liuxuan30
migrate Chart v3 code in master to swift 2.3 syntax
7af3bff
@liuxuan30
Merge branch 'Swift-2.3' into V3-Swift2.3
5a1a7ce
@liuxuan30 liuxuan30 merged commit cf95f69 into ChartsOrg:Swift-2.3 Sep 1, 2016
@liuxuan30 liuxuan30 deleted the V3-Swift2.3 branch September 1, 2016 03:14
@liuxuan30
Copy link
Member Author

this mess up #1387, I reseted swift 2.3 branch and use #1389 for a clean shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@liuxuan30 @pmairoldi @danielgindi @tuantmdev @ezamagni @VincentSit @AntiMoron @chris-gunawardena @essoecc