Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify offsetForDrawing and draw method in BallonMarker swift #1741

Closed
wants to merge 1 commit into from
Closed

Conversation

oxape
Copy link

@oxape oxape commented Oct 29, 2016

The MarkerView can't indicate actual position of data.
Before

simulator screen shot 2016 10 29 3 09 22

Now after modification.

simulator screen shot 2016 10 29 3 06 54
simulator screen shot 2016 10 29 3 07 08

@codecov-io
Copy link

codecov-io commented Oct 29, 2016

Codecov Report

❗ No coverage uploaded for pull request base (master@1ed1561). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1741   +/-   ##
=========================================
  Coverage          ?   18.68%           
=========================================
  Files             ?      123           
  Lines             ?    14052           
  Branches          ?        0           
=========================================
  Hits              ?     2626           
  Misses            ?    11426           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed1561...0a56492. Read the comment docs.

@liuxuan30
Copy link
Member

thanks @oxape! Please wait for a while as the review process could take time.. As you can see we are short handed and lots of questions and bugs to fix..

@danielgindi
Copy link
Collaborator

This is pretty. Can't wait to merge this :-)

@oxape
Copy link
Author

oxape commented Nov 5, 2016

I am very much looking forward

@jjatie
Copy link
Collaborator

jjatie commented Jan 12, 2018

Please rebase master

@jjatie jjatie self-assigned this Jan 12, 2018
@jjatie jjatie added this to the 3.1 milestone Jan 12, 2018
@liuxuan30
Copy link
Member

seems he deleted that branch..

@jjatie
Copy link
Collaborator

jjatie commented Jan 15, 2018

I guess I'll reimplement

@jjatie jjatie closed this Jan 15, 2018
jjatie pushed a commit that referenced this pull request Jan 15, 2018
@ChartsOrg ChartsOrg locked as resolved and limited conversation to collaborators Jan 15, 2018
@jjatie jjatie removed this from the 3.1 milestone Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants