ChartDataSet index o.o.b. check #1948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- return nil for index out of bounds to prevent crash on empty datasets Signed-off-by: Wytse van der Velde <w.h.vandervelde@gmail.com>
Current coverage is 18.67% (diff: 66.66%)@@ master #1948 diff @@
==========================================
Files 124 124
Lines 14083 14086 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2629 2631 +2
- Misses 11454 11455 +1
Partials 0 0
|
|
just saw #2167 get merged, and there are two similar PRs. I am closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return nil for index out of bounds to prevent crash on empty datasets (Fixes #1945)
Signed-off-by: Wytse van der Velde w.h.vandervelde@gmail.com