Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2222 move default backgroundColor to initialize() #2228

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

liuxuan30
Copy link
Member

@liuxuan30 liuxuan30 commented Mar 7, 2017

fix #2222
move default backgroundColor to initialize() as initWithCoder also needs it
I checked initialize() is only called in init(), so it seems safe to move there, to avoid duplicated code.

@codecov-io
Copy link

codecov-io commented Mar 7, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@1ed1561). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2228   +/-   ##
=========================================
  Coverage          ?   18.44%           
=========================================
  Files             ?      124           
  Lines             ?    14619           
  Branches          ?        0           
=========================================
  Hits              ?     2696           
  Misses            ?    11923           
  Partials          ?        0
Impacted Files Coverage Δ
Source/Charts/Charts/ChartViewBase.swift 24.44% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed1561...f2fc9dd. Read the comment docs.

@liuxuan30 liuxuan30 merged commit 04c5820 into ChartsOrg:master Apr 24, 2017
@liuxuan30 liuxuan30 deleted the 2222backgroundColor branch April 24, 2017 02:47
PeterSrost pushed a commit to sokol8/Charts that referenced this pull request Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default backgroundColor (nil) displays as black instead of clear.
2 participants