Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default template parameters #38

Merged
merged 11 commits into from
May 2, 2024
Merged

Conversation

kwabenantim
Copy link
Member

@kwabenantim kwabenantim commented May 1, 2024

Changes

  • Changed CppTypeInfo.decl : declaration_t to CppTypeInfo.decls : List[declaration_t] to hold multiple declarations for template instantiations.
  • Try quering for class declarations without default template args if the full form is not found e.g. try Foo<2> if Foo<2,2> is not found and Foo is templated like <A, B=A>.
  • Added a test for the above with a mesh example.
  • Changed CppModuleWrapperWriter.exposed_class_full_names: List[str] to CppModuleWrapperWriter.class_decls : List[pygccxml.declarations.class_t] to use the found declaration above for subsequent queries instead of the instantiated class name.
  • For clarity, separated the class discovery step (when module_info.use_all_classes == True) from the step associating each class (whether discovered or manually specified) with their correct declaration(s).

@kwabenantim kwabenantim added the bug label May 1, 2024
@kwabenantim kwabenantim self-assigned this May 1, 2024
@kwabenantim kwabenantim linked an issue May 1, 2024 that may be closed by this pull request
@kwabenantim kwabenantim marked this pull request as ready for review May 1, 2024 20:40
@kwabenantim kwabenantim merged commit 79fddca into develop May 2, 2024
5 checks passed
@kwabenantim kwabenantim deleted the 3-fix-template-parameters branch May 2, 2024 08:42
@kwabenantim kwabenantim linked an issue May 2, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unable to find declarations Fix Automatic Wrapper Generator Bugs
1 participant