Add YouTube channel tooltip support #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implements #148 (didn't see that until now) |
|
Also needs a rework on how it caches the channels, will look into tomorrow. |
|
|
|
Thanks snake man, you beat me to it |
pajlada
reviewed
Jun 27, 2021
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| - Made Reddit Score field in Livestreamfails tooltip use humanized value. (#164) | |||
| - Added support for customizable oEmbed resolving for websites with the `providers.json` file. See [`data/oembed/providers.json`](data/oembed/providers.json). Three new environment variables can be set. See [`internal/resolvers/oembed/README.md`](internal/resolvers/oembed/README.md) (#139, #152) | |||
| - Added support for YouTube channel links. (#157) | |||
There was a problem hiding this comment.
Changelog entry needs to move up to the ## Unreleased section
As pajlada said, cfg in main.go is a singleton that we shouldn't rely on in tests in case it'd change or get removed.
pajlada
requested changes
Jun 27, 2021
pajlada
reviewed
Jul 31, 2021
pajlada
reviewed
Jul 31, 2021
also reformatted some things automatically :tf:
pajlada
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This PR aims to add support for YouTube channel links. Currently it only supports
youtube.com/{channel,user,c}/<id_or_name>links. Ideally this would also extend to custom channel links such asyoutube.com/tranceluvbut that's up for discussion as to how.Tested locally and confirmed that
/user/,/channel/and/c/work.TODO:
youtube.com/c/<channel>linksSupportwon't do for nowyoutube.com/<channel>linksCloses #148