Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltips ignoring zoom/font changes #3687

Closed
wants to merge 2 commits into from
Closed

Fix tooltips ignoring zoom/font changes #3687

wants to merge 2 commits into from

Conversation

kornes
Copy link
Contributor

@kornes kornes commented Apr 19, 2022 •
edited
Loading

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Currently due to a bug, tooltips (emotes, badges, link preview, split header) are completely ignoring changes of zoom level or font size/style from settings. This PR fixes that.

Example with 1.3x zoom. Left side shows fixed tooltip, with zoom matching rest of the app. Right side is current behavior.
screen

tested on windows only

jupjohn
jupjohn approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@jupjohn jupjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for attacking some of these niggly little issues in Chatterino!

Felanbird
Felanbird approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

LosFarmosCTL
LosFarmosCTL approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@LosFarmosCTL LosFarmosCTL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as intended, I wanted to at least mention though that this has the unfortunate side effect of making all tooltips horrible on macOS, due to the existing scaling issues. (#1076 #1075 #2544) Really annoying, but not an issue with this PR, just makes fixing that general problem a bit more pressing.

chatterino 2022-04-20 at 15 59 53chatterino 2022-04-20 at 16 00 04

imagechatterino 2022-04-20 at 16 04 08

@kornes
Copy link
Contributor Author

kornes commented Apr 20, 2022 •
edited
Loading

so if i understand correctly, with this change mac tooltips are getting extra tiny (right screen) on default zoom?
might look into it in next PR

@LosFarmosCTL
Copy link
Contributor

Nah, the entire macOS UI is already extra tiny, the tooltips just weren’t affected previously because they were missing the scaling.

@jupjohn
Copy link
Contributor

jupjohn commented Apr 20, 2022

I wouldn't be comfortable merging this until we fix the DPI scaling or have some decent workaround for it. As great as this feature is, it will negatively impact macOS users + high DPI resolutions.

@kornes
Copy link
Contributor Author

kornes commented Apr 20, 2022

agree, made some progress on this, will PR tomorrow for tests

@kornes kornes mentioned this pull request Apr 22, 2022
Open
1 task
@kornes
Copy link
Contributor Author

kornes commented Apr 23, 2022

closing it, moved to #3690

@kornes kornes closed this Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jupjohn jupjohn jupjohn approved these changes

@Felanbird Felanbird Felanbird approved these changes

@LosFarmosCTL LosFarmosCTL LosFarmosCTL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kornes @LosFarmosCTL @jupjohn @Felanbird