feat: Warn for commands with duplicate triggers

[askepticaldreamer]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

Fixes #2497
Added warning tooltip for when user selected another cell and previous command name was a duplicate. Tried to force selection to the duplicate cell with the following

  int duplicateIndex = (i > previous.row()) ? i : previous.row();
  view->getTableView()->selectRow(duplicateIndex);
  view->getTableView()->selectColumn(0);

But didn't seem to work. Could leave as is with just tool tip warning or open to suggestions for methods to force user to change duplicate command name

[pajlada]

I think the friendliest way to handle this atm will be to not stop the user from renaming or creating commands with specific names, but to mark all commands with duplicate entries. This can be done by making them slightly yellow, or adding a ⚠️ icon to the start of the row.
In addition, a warning text should appear above or below the list if any of the commands have duplicate names

[pajlada]

Marked it as a draft until it solves it (or you think it solves the issue), feel free to poke me at any time before that if you want a review of the code or way you're trying to handle it

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy made some suggestions

[github-actions]

clang-tidy made some suggestions

[askepticaldreamer]

@pajlada what do you think of this approach? Am I overcomplicating things? The code is able to set text colors and add/remove the warning label as duplicates are added/removed but currently runs into an issue when it tries to set the color after removing an item or moving it up/down so not sure if I need a mutex somewhere or something.

[pajlada]

Looks alright, let's review in parts so you can work on these things first

[github-actions]

clang-tidy made some suggestions

[pajlada]

With this PR I'm able to crash Chatterino by:

1. Removing the last row (maybe removing any row?)
2. Dragging one row onto another

[pajlada]

I don't think a button for this is the right approach - if it cannot be figured out automatically then I don't think it provides much value for users

[pajlada]

If it's just there for you while testing then my bad, bit fast with the comments 😎

[github-actions]

clang-tidy made some suggestions

[pajlada]

Doesn't seem to be checking duplicates on row removal, and doesn't handle renaming from one duplicate to another duplicate well
https://user-images.githubusercontent.com/962989/218690818-94a129cd-91df-45b9-87c5-09937e4e6dfe.mp4

[askepticaldreamer]

@pajlada that's interesting, both those cases work on my machine. I'll record a video when I get a chance. Should be fun to debug lol.

[askepticaldreamer]

Was able to repro. Wasn't happening before since I was testing duplicate commands that weren't the one just added. Changed the signals and seems to work now

[Mm2PL]

lgtm