Fixed too much text being copied when copying chat messages #4812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
changed the title
pajlada
approved these changes
Sep 17, 2023
pajlada
force-pushed
the
fix/selection
branch
from
b6f2bb2
to
0d5315c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of #3080. The same approach is used.
Because of the reply button being in every message, setting
hasTrailingSpaceon the last element (even the last text element) when building as mentioned in #3080 (comment) doesn't work.Instead,
hasTrailingSpaceis set on the last layout element. With the button enabled, a trailing space is copied (as that space is visually selected). Without the button, no trailing space is copied. When selecting multiple lines, having no delimiter after a message is bad, so a newline is added (over a space to distinguish lines).Fixes #2449.
Additionally, this fixes the issue of copying emotes when they're not selected (e.g. in
a 🅰withaselected, Chatterino would copya 🅰).