streamlink: trim custom paths #4834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian6932
force-pushed
the
fix/trim-streamlink-custom-path-windows
branch
from
e88242f
to
967df2e
Compare
brian6932
force-pushed
the
fix/trim-streamlink-custom-path-windows
branch
from
967df2e
to
127a472
Compare
|
I don't think there would be any issue with trimming this path for other platforms as well, can anyone else come up with any scenarios where that would be unwanted? |
|
Technically other platforms do allow whitespace at the end of folder names |
Yea this is why I didn't want to do that, just in the case that someone had such an edge case. |
Felanbird
approved these changes
Sep 23, 2023
pajlada
approved these changes
Sep 23, 2023
pajlada
changed the title
Nerixyz
pushed a commit
to SevenTV/chatterino7
that referenced
this pull request
Sep 28, 2023
this makes sure no spaces are accidentally left in the custom path Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows paths can't have trailing whitespace, currently having trailing whitespace in the path will result in the path not being found