Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust DontFocus window flags on Windows and macOS #4876

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Oct 7, 2023

Description

Adds WindowDoesNotAcceptFocus (Informs the window system that this window should not receive the input focus). "Removes" X11BypassWindowManagerHint (alias to BypassWindowManagerHint).

Seems to be what we want. I couldn't test it on macOS, so I would be grateful if anyone could test it there. The only other window using this flag is the tooltip.

Fixes #2211.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on macOS now, previously it wouldn't accept me dragging the scrollbar - now it does.

@pajlada pajlada merged commit 4db93bf into Chatterino:master Oct 7, 2023
15 checks passed
@Nerixyz Nerixyz deleted the fix/allow-click-scroll branch October 7, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on emote selection menu scrollbar closes said menu
2 participants