Refactored the Image Uploader feature. #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
force-pushed
the
chore/refactor_image_uploader
branch
from
42427bf
to
e3e169f
Compare
Mm2PL
force-pushed
the
chore/refactor_image_uploader
branch
from
e3e169f
to
5c00d0d
Compare
Mm2PL
changed the title
Mm2PL
force-pushed
the
chore/refactor_image_uploader
branch
from
9bbcfab
to
69078d1
Compare
Bonus feature: this doesn't trigger link resolver both preventing leaking the delete link to the api and now the API can't know who uploaded what image based on timing.
Mm2PL
force-pushed
the
chore/refactor_image_uploader
branch
from
69078d1
to
f045ae1
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…internet connection
pajlada
approved these changes
Nov 19, 2023
|
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's not an uploader only for
i.nuuls.comanymore.Changes:
I still want to edit this branch and will force push :)