Hide the Usercard button in the User Info Popup in special channels #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornes
approved these changes
Nov 21, 2023
Comment on lines
746
to
748
| if (auto *tc = dynamic_cast<TwitchChannel *>(this->channel_.get()); | ||
| tc == nullptr) | ||
| { |
There was a problem hiding this comment.
this will also hide button from /mentions or search where it works as expected,
could be changed to check if channel type is TwitchWhispers or TwitchLive
|
The |
pajlada
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
I've tested this & made sure it opened as expected in:
- Normal Twitch channels - it correctly shows the button
/mentions- it correctly shows the button & uses the channel the message was originally sent in/whispers- it correctly hides the button, previously it would show the button & take me tohttps://www.twitch.tv/popout//whispers/viewercard/testaccount_420/automod- it currectly shows the button & uses the channel the offending message was sent in/live- it correctly hides the button, previously it would show the button & take me tohttps://www.twitch.tv/popout//live/viewercard/pajlada
I have not tried /watching since I'm on Linux btw
pajlada
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #550.