fix: Only display spaces between words in reply context #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what the Windows 5.15 issue is (I suspect it's my [telegram's] qstringliteral). |
I should've read the logs. |
|
Seems like the highlight controller test is broken. |
Yeah, we noticed it when creating the tests. With Qt 6.2.4 it seemed to have worked but with Qt 6.5.0 it times out. I played around with it here: Wissididom#19 |
Off-topic: We probably want to run tests in debug mode on macOS and Windows as well. |
pajlada
approved these changes
Nov 26, 2023
pajlada
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were some bugs regarding spaces and emojis in the reply context (a missing one before an emoji in
abc 😂 defand an invalid one inabc😂def).This PR fixes the bugs and adds tests for emoji parsing.
boost::variant, is that still necessary?EmojiMap emojisinEmojiscan be astd::vector, since the key is only used in tests and benchmarks.