feat: add sound and flash alert for automod caught messages #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
Dec 16, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
While the new default highlight row has been added, this PR is still a draft since automod messages don't work through SharedMessageBuilder, so |
iProdigy
changed the title
This allows us to rely on something other than the badges, in case we forward badges somehow later
everything is now under `/highlighting/automodHighlight/`
pajlada
reviewed
Dec 25, 2023
There was a problem hiding this comment.
The only thing that's questionable to me right now is the color
For other highlights, this colors both the message itself & the scrollbar.
For this, we only color the scrollbar.
Maybe it's best to just leave out the color entirely until we figure out what makes most sense?
|
Yeah I'm not tied to having any scrollbar color (old caught messages are likely to be unactionable anyways), so we can remove it for now (and changing the message background could look strange) |
pajlada
approved these changes
Dec 25, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When automod split isn't present in the current tab (or chatterino is minimized), moderators may not realize an automod caught message has been received. This PR allows a sound notification and/or taskbar flash upon receiving a caught message