Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add badges, emotes, and filters for suspicious messages #5060

Merged

Conversation

iProdigy
Copy link
Contributor

@iProdigy iProdigy commented Jan 1, 2024

Follow-up to #5056

image

Now the only remaining todo (for a separate PR) is rendering monitored messages based on pubsub instead of irc

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/pubsubmessages/LowTrustUsers.cpp Outdated Show resolved Hide resolved
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits before a more proper review

src/Application.cpp Outdated Show resolved Hide resolved
src/providers/twitch/TwitchMessageBuilder.cpp Outdated Show resolved Hide resolved
src/providers/twitch/TwitchMessageBuilder.cpp Outdated Show resolved Hide resolved
src/providers/twitch/pubsubmessages/LowTrustUsers.cpp Outdated Show resolved Hide resolved
src/providers/twitch/pubsubmessages/LowTrustUsers.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

iProdigy and others added 6 commits January 2, 2024 00:10
Without this change, we would have the possibility of using the
TwitchChannel after the Channel itself has gone out of scope, albeit not
realistically since we just post this to a thread and parse it - there's
no networking or big delays involved. but this shows the intent better
@pajlada pajlada enabled auto-merge (squash) January 6, 2024 12:19
@pajlada pajlada merged commit 693d4f4 into Chatterino:master Jan 6, 2024
20 checks passed
@iProdigy iProdigy deleted the feature/low-trust-user-message-badges branch January 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants