feat: Show FrankerFaceZ channel badges #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
force-pushed
the
feat/ffz-channel-specific-badge-assignments
branch
from
d49cb52
to
7bf36f8
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Useful for various boost containers we might use in the upcoming commits (subscribe and see!)
This currently only supports bot badges, but could theoretically support other badges.
channel-specific ffz badges
pajlada
force-pushed
the
feat/ffz-channel-specific-badge-assignments
branch
from
e62ff2f
to
331416e
Compare
|
@pajlada Tested on macOS and it looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already make the request, so this just parses more of the payload.
One thing of note, for the API parsing: FrankerFaceZ gives us Twitch User IDs as integers, while we always treat them as strings. For this, I've made sure to handle a potential change in the API if they change to strings.
For thread safety, I've added a thread guard which will assert in debug mode if the channel badge map is accessed or written to in different threads. On Arch Linux with Qt 6.6.3 this works as expected. This should be tested on macOS & Windows builds.
Fixes #2241