Live streams that are marked as reruns now mark a tab as yellow instead of red #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
Feb 15, 2024
Mm2PL
force-pushed
the
feature/reintroduce-reruns
branch
from
325dbe1
to
599a385
Compare
Mm2PL
force-pushed
the
feature/reintroduce-reruns
branch
from
599a385
to
1ff2cb5
Compare
|
The yellow blip is not fully yellow, other than that this works as expected It would also be nice if you add a comment to the red & yellow blip to say that they should be themeable |
|
I agree on adding theming but I believe this is out of scope of this PR. |
Agreed - don't implement theming here but since we have multiple dots now it would be nice to have a comment regarding it for future adventurers |
pajlada
approved these changes
Feb 18, 2024
pajlada
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They removed official rerun field in Helix, so we have to rely on a hack now, but it works. Fixes #2648.
This was really simple and easy to make surprisingly.