-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option always include broadcaster in user completions #5193
Add option always include broadcaster in user completions #5193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Maybe the setting name could be a bit shorter with some tooltip text, but I can't think of anything good right now 🙃
If you want, you could add a test case (maybe testing the case-sensitivity).
The "at the top" isn't important to me, just that the streamer is included. So for the variable names & the setting labels that should be reflected (e.g. "always include broadcaster in user completions" or something) |
Changed the setting name (might be too big now but I feel like it's reads well) |
@pajlada ended up using |
Settings text probably needs to be improved.
Setting off:
Setting on:
I noticed we got some unit tests for ChatterSet, so let me know if I should add any.
Fixes: #5190