Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin permissions and IO API #5231

Merged
merged 37 commits into from
Mar 9, 2024
Merged

Add plugin permissions and IO API #5231

merged 37 commits into from
Mar 9, 2024

Commits on Mar 1, 2024

  1. Add basicest plugin permission parsing

    @Mm2PL
    Mm2PL committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bcdbcb8 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Add Plugin::hasFSPermissionFor utility function

    @Mm2PL
    Mm2PL committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    a3ff7de View commit details
    Browse the repository at this point in the history

  2. Add wrappers for (almost all) IO functions 

    This does not include io.popen. And io.type is used without a wrapper.
    @Mm2PL
    Mm2PL committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4d1f827 View commit details
    Browse the repository at this point in the history

  3. Disallow commas in file paths

    @Mm2PL
    Mm2PL committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4313d0b View commit details
    Browse the repository at this point in the history

  4. Unrelated: Ensure that lua::pop(lua_State*, T*) is always balanced, 

    even if it fails.
    @Mm2PL
    Mm2PL committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4a01239 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Restrict plugins' io to only a data directory

    @Mm2PL
    Mm2PL committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    923e3b6 View commit details
    Browse the repository at this point in the history

  2. This is documented to be <algorithm> instead

    @Mm2PL
    Mm2PL committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6dde7bc View commit details
    Browse the repository at this point in the history

  3. Add stubs for io.popen and io.tmpfile to ease porting of existing Lua… 

    … code
    @Mm2PL
    Mm2PL committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c83ab5b View commit details
    Browse the repository at this point in the history

  4. Make open relative to data directory instead of plugin

    @Mm2PL
    Mm2PL committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    2c5bbc7 View commit details
    Browse the repository at this point in the history

  5. Document relative file behavior

    @Mm2PL
    Mm2PL committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b5d4e4e View commit details
    Browse the repository at this point in the history

  6. rewrite string - how did i write this

    @Mm2PL
    Mm2PL committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b77a93c View commit details
    Browse the repository at this point in the history

  7. Rename PluginPermission::toHtmlEscaped to toHtml

    @Mm2PL
    Mm2PL committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3983fc7 View commit details
    Browse the repository at this point in the history

  8. Reformat PluginPermission.hpp

    @Mm2PL
    Mm2PL committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a00382d View commit details
    Browse the repository at this point in the history

  9. Actually use isValid

    @Mm2PL
    Mm2PL committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    891f3da View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Document behavior of lua::pop()

    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9e850c6 View commit details
    Browse the repository at this point in the history

  2. Reword error strings and validate the string in LuaFileMode constructor

    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    47b3578 View commit details
    Browse the repository at this point in the history

  3. Reformat IOWrapper.cpp

    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0e526c5 View commit details
    Browse the repository at this point in the history

  4. Make errors conform better to how Lua does them

    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5241b80 View commit details
    Browse the repository at this point in the history

  5. i fucking hate prettier

    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4e9ca37 View commit details
    Browse the repository at this point in the history

  6. changelog

    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    98d9b7f View commit details
    Browse the repository at this point in the history

  7. ShutUpOldGcc names an order.

    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3c877d5 View commit details
    Browse the repository at this point in the history

  8. control DOES NOT REACH THE end of non-void function

    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e0c9be6 View commit details
    Browse the repository at this point in the history

  9. ah old compilers what would we do without them

    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2655251 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/master' into feature/plugin-perm… 

    …issions
    @Mm2PL
    Mm2PL committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    df7d2c8 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Document permissions

    @Mm2PL
    Mm2PL committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    708d273 View commit details
    Browse the repository at this point in the history

  2. Document IO api

    @Mm2PL
    Mm2PL committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5357be2 View commit details
    Browse the repository at this point in the history

  3. Include header links inside of docs/wip-plugins.md

    @Mm2PL
    Mm2PL committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    11c5bb3 View commit details
    Browse the repository at this point in the history

  4. Unrelated: Make sure c2.Channel functions get a channel instead of any 

    user data.
Prevents possible out of bounds reads. To see this even exist you would
have needed a userdatum smaller than chatterino::lua::api::UserData in
which case our program would die a horrible death by segmentation fault.
    @Mm2PL
    Mm2PL committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    d6fa4d4 View commit details
    Browse the repository at this point in the history

  5. shut up uglier

    @Mm2PL
    Mm2PL committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c9ea3bc View commit details
    Browse the repository at this point in the history

  6. Use "enum" instead of "examples"

    @Mm2PL
    Mm2PL committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    08ef872 View commit details
    Browse the repository at this point in the history

  7. Unrelated: Clarify plugin schema license field.

    @Mm2PL
    Mm2PL committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e4bbedd View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Add missing #pragma once and reformat includes

    @Mm2PL
    Mm2PL committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    115f23e View commit details
    Browse the repository at this point in the history

  2. Only run error copy loop if there are errors

    @Mm2PL
    Mm2PL committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    7b927f2 View commit details
    Browse the repository at this point in the history

  3. Change permission example snippets to show the structure of info.json

    @Mm2PL
    Mm2PL committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    4ed9e77 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:Chatterino/chatterino2 into featu… 

    …re/plugin-permissions
    @Mm2PL
    Mm2PL committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    555683f View commit details
    Browse the repository at this point in the history

  5. s/err/perm

    @Mm2PL
    Mm2PL committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    de45a05 View commit details
    Browse the repository at this point in the history

  6. Do not load data as code :)

    @Mm2PL
    Mm2PL committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    5a5e3ae View commit details
    Browse the repository at this point in the history