fix: rerender when unpausing #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "double click to open links..." is on and a user (single) clicked in a channel, the indicator wouldn't disappear.
Even though we call
queueLayout(), this might not cause a rerender. So this PR adds aupdate()to make sure a rerender is done if needed (= if visible).While testing, I noticed some
QTimer cannot have a negative intervallogs, so I made sure the duration never gets negative.Furthermore, I think double-clicking on a link shouldn't select it, it should only open. This would make it impossible to select links by double-clicking, but I can't really see a use-case for that.
Fixes #5088.