-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: report duration for multi-month anon sub gifts #5293
feat: report duration for multi-month anon sub gifts #5293
Conversation
can you put one of these in |
actually the system message is good when the gift is not anonymous, will adjust my patch
|
.arg(QString::number(months), | ||
tags.value("msg-param-sub-plan") | ||
.toString() | ||
.at(0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can throw if msg-param-sub-plan
is set, but is an empty string.
See how SubtierPredicate.cpp does it https://github.com/Chatterino/chatterino2/blob/master/src/messages/search/SubtierPredicate.cpp#L25-L26
.arg(QString::number(months), | ||
tags.value("msg-param-sub-plan") | ||
.toString() | ||
.at(0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can throw if msg-param-sub-plan
is set, but is an empty string.
See how SubtierPredicate.cpp does it https://github.com/Chatterino/chatterino2/blob/master/src/messages/search/SubtierPredicate.cpp#L25-L26
hm, not quite; observed a broadcaster gift a 12 month sub and the system-msg didn't include the number of months. may be related to
(removed broadcaster info) |
Similar to #2026 but for subgift (and these irc tags are actually documented)
Before
After