Implement concurrency mechanism #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avoid duplicated requests
|
KICS version: v1.6.13
|
Merged
joaopedrocsilva
force-pushed
the
joaocs/conc
branch
from
8a49555
to
d9f2b70
Compare
jossef
approved these changes
Apr 26, 2023
baruchiro
reviewed
May 1, 2023
Comment on lines
+152
to
+153
| // Wait for last secret to be added to report | ||
| time.Sleep(time.Millisecond * timeSleepInterval) |
There was a problem hiding this comment.
Hi @joaopedrocsilva , very nice work, I added this to my PR #53.
I have one question... why we are sleeping here? Why the waitGroup is not helping us?
There was a problem hiding this comment.
Hey @baruchiro.
Couln't understand why but without the sleep we can't get all elements.
Maybe it would make sense to spend some time investigating if it's realated to issues on goroutines management or it's related to some kind of limitations.
jossef
pushed a commit
that referenced
this pull request
May 11, 2023
Resolves #31 ### Features - We expect the user to give us a *Personal Access Token*. This token can be retrieved from the browser *Dev Tool*, or by authenticating a *Discord App*. See #31 (comment). - The user must give at least one `--discord-server`, we will not loop over all the user's servers. - The *Server* in Discord called *Guild* in the API. - If the user doesn't give `--discord-channel`, we will scan all the channels in a server. - We will scan all messages until `--discord-duration` or `--discord-messages-count` (the closest one). - **Threads**: Only *bots* can get all the **threads** from a **channel**. As we currently use *Personal Access Token*, we can get the **thread** from the **message** started it. So we will scan the **threads** that *started* in the time/limit arguments (as they are messages that scanned), and for each **thread** we will scan the messages in the time/limit requirements. ### Questions - It is a little confusing if you give multiple **servers** and multiple **channels**, because each **channel** relates to its **server**, and also if you will give **channels** only for one **server**, the other **server** will not be scanned at all. Compared to *Confluence*, which has **servers** and **spaces**, we are not scanning multiple **servers** in one scan. Waits for #52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement suggested concurrency logic
Also added confluence window constant to avoid duplicated requests
Added a time.Sleep since without that the last item wasn't being added to the list of results