Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(docs): community tab added into the docs.kics.io website #5806

Merged
merged 10 commits into from
Sep 28, 2022
Merged

update(docs): community tab added into the docs.kics.io website #5806

merged 10 commits into from
Sep 28, 2022

Conversation

gabriel-cx
Copy link
Contributor

Proposed Changes

  • Community tab added into the docs.kics.io web page

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added the documentation Improvements or additions to documentation label Sep 20, 2022
@gabriel-cx gabriel-cx marked this pull request as ready for review September 28, 2022 09:53
cxMiguelSilva
cxMiguelSilva requested changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the link to Hacktoberfest should either be incorporated in the sentence or add a quote like:
to know more about Hacktoberfest check the official page

docs/community.md Outdated Show resolved Hide resolved
docs/community.md Outdated Show resolved Hide resolved
@gabriel-cx @cxMiguelSilva
Update docs/community.md
f5b24b8 
Co-authored-by: Miguel Silva <100352574+cxMiguelSilva@users.noreply.github.com>
cxMiguelSilva
cxMiguelSilva approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rafaela-soares
rafaela-soares approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gabriel-cx gabriel-cx merged commit 36e33f0 into master Sep 28, 2022
@gabriel-cx gabriel-cx deleted the kics/communitytab branch September 28, 2022 11:27
@rafaela-soares rafaela-soares changed the title community tab added into the docs.kics.io website update(docs): community tab added into the docs.kics.io website Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@rafaela-soares rafaela-soares rafaela-soares approved these changes

@nunoocx nunoocx Awaiting requested review from nunoocx

@kaplanlior kaplanlior Awaiting requested review from kaplanlior

@joaoReigota1 joaoReigota1 Awaiting requested review from joaoReigota1

@anterosilva1985 anterosilva1985 Awaiting requested review from anterosilva1985

Assignees

@gabriel-cx gabriel-cx

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabriel-cx @rafaela-soares @cxMiguelSilva