Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): update s3 bucket policy accepts http requests security query #5832

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

Closes #5763

Proposed Changes

  • update s3 bucket policy accepts http requests security to unmarshal JSON before the function
  • add a negative sample

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added bug Something isn't working query New query feature terraform Terraform query aws PR related with AWS Cloud labels Sep 23, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Sep 23, 2022
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit 9eeb00b into master Sep 23, 2022
@rafaela-soares rafaela-soares deleted the fix/5763 branch September 23, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws PR related with AWS Cloud bug Something isn't working query New query feature terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 Bucket HTTP access false positive
2 participants