Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): correct GCP KMS crypto key rotation period queries + descriptions #5863

Merged
merged 1 commit into from
Oct 3, 2022
Merged

fix(query): correct GCP KMS crypto key rotation period queries + descriptions #5863

merged 1 commit into from
Oct 3, 2022

Conversation

Churro
Copy link
Contributor

@Churro Churro commented Sep 30, 2022

Problem

  • The same query differs for Ansible and TF queries regarding the checked criteria: > 7776000, < 7776000
  • The Ansible testcase is wrong as it checks the opposite

Proposed Changes

  • Streamline both queries
  • Extend description to include reasoning

I submit this contribution under the Apache-2.0 license.

cxMiguelSilva
cxMiguelSilva approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaela-soares rafaela-soares added community Community contribution query New query feature labels Oct 3, 2022
rafaela-soares
rafaela-soares approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you so much, @Churro!

@rafaela-soares rafaela-soares merged commit 071fbba into Checkmarx:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@rafaela-soares rafaela-soares rafaela-soares approved these changes

Assignees
No one assigned
Labels
community Community contribution query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Churro @rafaela-soares @cxMiguelSilva