fix(query): cover additional deprecated API versions in k8s rule #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaela-soares
suggested changes
Oct 3, 2022
There was a problem hiding this comment.
Hello, @Churro! Thank you so much for remembering and updating it!
Regarding the category suggestion, I will talk with the AppSec team and I will let you know as soon as possible.
Meanwhile, can you please add the new result (line 94) in the positive_expect_result.json?
|
Done, thanks for the hint, @rafaela-soares 👍 |
|
Hi Johannes (@Churro), Another relevant suggestion. Thank you! |
|
Done, thanks for cross-checking 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I submit this contribution under the Apache-2.0 license.