Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): terraform alb_is_not_integrated_with_waf #6636

Merged
merged 6 commits into from
Oct 3, 2023
Merged

fix(query): terraform alb_is_not_integrated_with_waf #6636

merged 6 commits into from
Oct 3, 2023

Conversation

cx-henriqueAlvelos
Copy link
Contributor

Closes #6334

Proposed Changes

  • Added aws_wafv2_web_acl_association to possible resource
  • Tests
  • Positive Expected Results

I submit this contribution under the Apache-2.0 license.

@cx-henriqueAlvelos cx-henriqueAlvelos self-assigned this Aug 11, 2023
@github-actions github-actions bot added query New query feature terraform Terraform query labels Aug 11, 2023
@cx-henriqueAlvelos cx-henriqueAlvelos added the bug Something isn't working label Aug 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023 •
edited
Loading

kics-logo

KICS version: v1.7.8

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@github-actions github-actions bot removed the bug Something isn't working label Aug 11, 2023
@github-actions github-actions bot added the aws PR related with AWS Cloud label Sep 15, 2023
@github-actions github-actions bot added the community Community contribution label Oct 2, 2023
@asofsilva asofsilva merged commit 898fa35 into master Oct 3, 2023
18 checks passed
@asofsilva asofsilva deleted the kics-997 branch October 3, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx

@pereiramarco011 pereiramarco011 Awaiting requested review from pereiramarco011

Assignees

@cx-henriqueAlvelos cx-henriqueAlvelos

Labels
aws PR related with AWS Cloud community Community contribution query New query feature terraform Terraform query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform ALB Without WAF Should Include wafv2
4 participants
@cx-henriqueAlvelos @cxMiguelSilva @asofsilva @JoaoAtGit