Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): dockerfile unpinned_package_version_in_pip_install #6637

Merged
merged 7 commits into from
Oct 9, 2023
Merged

fix(query): dockerfile unpinned_package_version_in_pip_install #6637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
da6768e
fix(query): dockerfile unpinned_package_version_in_pip_install
cx-henriqueAlvelos Aug 11, 2023
a0a14b5
fix getPackages
cx-henriqueAlvelos Aug 11, 2023
46dc062
fixed counter and args
cx-henriqueAlvelos Aug 12, 2023
5e7e343
fixed function
cx-henriqueAlvelos Aug 12, 2023
bbfd0fc
fixed count
cx-henriqueAlvelos Aug 12, 2023
01e697b
Merge branch 'master' into kics-998
cx-henriqueAlvelos Sep 15, 2023
5d06ab3
Merge branch 'master' into kics-998
JoaoAtGit Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions assets/queries/dockerfile/unpinned_package_version_in_pip_install/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package Cx

import data.generic.dockerfile as dockerLib

flags = ["-r", "-c"]

CxPolicy[result] {
resource := input.document[i].command[name][_]
resource.Cmd == "run"
Expand All @@ -13,10 +15,13 @@ CxPolicy[result] {
yum != null

packages = dockerLib.getPackages(commands, yum)
length := count(packages)
refactorPackages = [ x | x := packages[_]; x != ""]
length := count(refactorPackages)

count({x | x := refactorPackages[_]; x == flags[_]}) == 0

some j
analyzePackages(j, packages[j], packages, length)
analyzePackages(j, refactorPackages[j], packages, length)

result := {
"documentId": input.document[i].id,
Expand Down Expand Up @@ -57,7 +62,7 @@ isPip(command) {
contains(command[j], "install")
}

analyzePackages(j, currentPackage, packages, length) {
analyzePackages(j, currentPackage, _, length) {
j == length - 1
regex.match("^[a-zA-Z]", currentPackage) == true
not dockerLib.withVersion(currentPackage)
Expand Down
0 ...n_in_pip_install/test/negative.dockerfile → ..._in_pip_install/test/negative1.dockerfile
View file
Open in desktop
File renamed without changes.
9 changes: 9 additions & 0 deletions assets/queries/dockerfile/unpinned_package_version_in_pip_install/test/negative2.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
FROM alpine:3.4
RUN apk add --update py-pip=7.1.2-r0
RUN pip3 install -r pip_requirements.txt
COPY requirements.txt /usr/src/app/
RUN pip install --no-cache-dir -r /usr/src/app/requirements.txt
COPY app.py /usr/src/app/
COPY templates/index.html /usr/src/app/templates/
EXPOSE 5000
CMD ["python", "/usr/src/app/app.py"]
9 changes: 9 additions & 0 deletions assets/queries/dockerfile/unpinned_package_version_in_pip_install/test/negative3.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
FROM alpine:3.4
RUN apk add --update py-pip=7.1.2-r0
RUN pip3 install -c constraints.txt
COPY requirements.txt /usr/src/app/
RUN pip install --no-cache-dir -r /usr/src/app/requirements.txt
COPY app.py /usr/src/app/
COPY templates/index.html /usr/src/app/templates/
EXPOSE 5000
CMD ["python", "/usr/src/app/app.py"]
0 ...n_in_pip_install/test/positive.dockerfile → ..._in_pip_install/test/positive1.dockerfile
View file
Open in desktop
File renamed without changes.
12 changes: 8 additions & 4 deletions ...ies/dockerfile/unpinned_package_version_in_pip_install/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,25 @@
{
"queryName": "Unpinned Package Version in Pip Install",
"severity": "MEDIUM",
"line": 3
"line": 3,
"filename": "positive1.dockerfile"
},
{
"queryName": "Unpinned Package Version in Pip Install",
"severity": "MEDIUM",
"line": 4
"line": 4,
"filename": "positive1.dockerfile"
},
{
"queryName": "Unpinned Package Version in Pip Install",
"severity": "MEDIUM",
"line": 15
"line": 15,
"filename": "positive1.dockerfile"
},
{
"queryName": "Unpinned Package Version in Pip Install",
"severity": "MEDIUM",
"line": 18
"line": 18,
"filename": "positive1.dockerfile"
}
]
Loading