add bi aggregation function of min OK and exact OK #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kain88-de
added
enhancement
|
@kain88-de Where the new translations can be added or will you do that? What else is needed here? Only rebase? |
CheckmkCI
force-pushed
the
master
branch
2 times, most recently
from
875a494
to
3419412
Compare
|
Dear Checkmk Contributor! Unfortunately, we had to re-write our git-repo history, rendering your PR auto-closed. We will therefore rebase your PR onto the current master and reopen it again. Sorry for the inconvenience. |
|
Dear Contributor. Unfortunately, we learned that re-opening a PR which was force-rebased, is not possible (see isaacs/github#361). Therefore we kindly ask you to create a new PR for your change. We apologize for the circumstances and will implement technical measures to prevent such incidents in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your interest in contributing to Checkmk!
Unfortunately, due to our current work load, we only consider pure bug fixes as stated in our Readme.
This means any new pull request that is not a pure bug fix will be closed.
Instead of creating a PR, please consider sharing new check plugins, agent plugins, special agents or notification plugins via the Checkmk Exchange.
General information
At the moment the aggregation function of BI only got count of OK nodes bigger or same as (>=). But having a count of exact OK nodes would have the option to check if there is only one Master node in an HA-Setup or more.
Bug reports
...
Proposed changes
The change here will add another option of exact OK nodes. So if I put it to
1then only 1 OK nodes are ok and not 2.Therefore the recent "CountOK" was set to
==and add another function was added calledMinOKwhich is calculating the OK as it was before ">=".I have tested it and it worked. But the translation of the new options still needs to be added.