Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated theme #1

Merged
merged 1 commit into from
Oct 11, 2022
Merged

updated theme #1

merged 1 commit into from
Oct 11, 2022

Conversation

funkill
Copy link

@funkill funkill commented Oct 10, 2022

Sync theme with mdbook. Renders without artifacts. But script for change lang dummy needs changing for correct work.

Снимок экрана 2022-10-10 в 22 42 17

Motivation

(Write your motivation for proposed changes here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)

@funkill
Copy link
Author

funkill commented Oct 10, 2022

Here script takes second item from path and changes it. If book serverd in subpath (e.g. domain.com/path/book/<lang>) this script redirects to wrong url. Currently i haven't any ideas how change url more pretty

@SuccinctPaul
Copy link
Owner

Thanks for help me.

For the url, actually It doesn't matter. We can make it more beautiful by only move the contents in /book/i18n/.
Like https://chengyuejia.github.io/move/en/introduction.html and https://chengyuejia.github.io/move/zh/introduction.html.

For more detail, you can see my .workflow

@SuccinctPaul SuccinctPaul merged commit 1a0403f into SuccinctPaul:main Oct 11, 2022
@SuccinctPaul
Copy link
Owner

I've view it . It works fine. Thank you for help me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants