Structured Webhook Events #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChezCrawford
force-pushed
the
fb/structured-webhook-events
branch
from
2dcd81b
to
9c12ecf
Compare
ChezCrawford
commented
Mar 18, 2022
| @@ -13,6 +13,7 @@ type OutboundEventData struct { | |||
| Object map[string]interface{} | |||
| // The raw json data for use in structured unmarshalling. | |||
| RawData json.RawMessage | |||
| Type string | |||
There was a problem hiding this comment.
I'm not currently making this of type EventDataType as that would break support unstructured event handling.
ChezCrawford
commented
Mar 18, 2022
| IncidentNote EventDataType = "incident_note" | ||
| ) | ||
|
|
||
| type IncidentEvent struct { |
There was a problem hiding this comment.
TODO: Come back and complete this if we actually agree on this approach.
ChezCrawford
commented
Mar 18, 2022
| @@ -0,0 +1,58 @@ | |||
| package webhookv3 | |||
There was a problem hiding this comment.
The structured events are in a separate file so that it is easier to review simple PRs that add new event types and/or fields without changing any cross-cutting functionality or behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layers on support for structured events as well.