make tree_hash() support CLVM with backrefs #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
arvidn
force-pushed
the
tree-hash-from-bytes
branch
3 times, most recently
from
6c8f3c8
to
fb13003
Compare
Pull Request Test Coverage Report for Build 7872334961Details
💛 - Coveralls |
arvidn
force-pushed
the
tree-hash-from-bytes
branch
from
fb13003
to
5557f6f
Compare
Rigidity
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think anything depends on this (yet), but not supporting it is inconsistent between
SerializedProgramandProgram(inchia-blockchain) and a risk.There are optimizations to improve performance of computing the tree hash for clvm structures with backrefs that I intend to explore. But the first step is to support it in the first place.