src|python-bindings: Use std::vector<uint8_t> for id and memo
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
approved these changes
Aug 6, 2021
src/prover_disk.hpp
Outdated
| void GetMemo(uint8_t* buffer) { memcpy(buffer, memo, this->memo_size); } | ||
|
|
||
| uint32_t GetMemoSize() const noexcept { return this->memo_size; } | ||
| std::vector<uint8_t> GetMemo() { return memo; } |
There was a problem hiding this comment.
would it make sense for this to return a span<const uint8_t> or a const std::vector<uint8_t>&? (as well as GetId() below)
There was a problem hiding this comment.
I agree span would be nice in many places but we have C++17 set here still so this feels out of scope. I changed the return to const reference though 👍 (https://github.com/Chia-Network/chiapos/compare/fb796346df762224973f92d4628b6e994b49ba00..b06302c6fc9f9c914110002698d91f3741cea6c6)
xdustinface
force-pushed
the
pr-disk-prover-vector
branch
from
fb79634
to
b06302c
Compare
arvidn
approved these changes
Aug 9, 2021
python-bindings/chiapos.cpp
Outdated
| delete[] memo; | ||
| return ret; | ||
| std::vector<uint8_t> memo = dp.GetMemo(); | ||
| return py::bytes(reinterpret_cast<char*>(memo.data()), memo.size()); |
There was a problem hiding this comment.
Its probably not a big deal, but this will copy the buffer twice, where i would think once is enough
python-bindings/chiapos.cpp
Outdated
| py::bytes ret = py::bytes(reinterpret_cast<char *>(id), kIdLen); | ||
| delete[] id; | ||
| return ret; | ||
| std::vector<uint8_t> id = dp.GetId(); |
xdustinface
force-pushed
the
pr-disk-prover-vector
branch
from
b06302c
to
2f8e259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.