Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new clippy traffic #89

Merged
merged 2 commits into from
May 17, 2024
Merged

new clippy traffic #89

merged 2 commits into from
May 17, 2024

Conversation

prozacchiwawa
Copy link
Contributor

update for most recent clippy before the ci tooling updates.

@coveralls
Copy link

coveralls commented May 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9005463757

Details

  • 12 of 13 (92.31%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 82.719%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/classic/clvm_tools/cmds.rs 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
src/compiler/sexp.rs 1 81.55%
Totals Coverage Status
Change from base Build 8913748858: -0.2%
Covered Lines: 14891
Relevant Lines: 18002
💛 - Coveralls

@prozacchiwawa
Update wasm-bindgen as a deprecation warning was coming from code gen…
0a8081c 
…erated by the earlier version we captured and that led to a test failure
@cmmarslender cmmarslender mentioned this pull request May 17, 2024
Merged
@prozacchiwawa
Copy link
Contributor Author

thanks

@prozacchiwawa prozacchiwawa merged commit b6c8276 into base May 17, 2024
31 checks passed
@prozacchiwawa prozacchiwawa deleted the 20240508-clippy branch May 17, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prozacchiwawa @coveralls @AmineKhaldi